Test PR for #6367

[mavasani]

Test PR for #6367

[mavasani]

@Youssef1313

[codecov]

Codecov Report

Merging #6375 (8680739) into main (43348f5) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6375   +/-   ##
=======================================
  Coverage   96.10%   96.11%           
=======================================
  Files        1361     1361           
  Lines      316050   316050           
  Branches    10186    10186           
=======================================
+ Hits       303752   303757    +5     
+ Misses       9868     9865    -3     
+ Partials     2430     2428    -2     

[Youssef1313]

@mavasani This is green :(

[mavasani]

Yes, will investigate why the analyzers are not executing

[mavasani]

@Youssef1313 The problem seems to be that we enable CAxxxx rules as warnings with the below:

roslyn-analyzers/src/Directory.Build.props

Lines 29 to 32 in 2b5a3b2

	<PropertyGroup>
	<!-- Enable all the latest CA rules from 'Microsoft.CodeAnalysis.NetAnalyzers' as build warnings by default. Specific rules are disabled or downgraded in repo's editorconfig. -->
	<AnalysisLevel>latest</AnalysisLevel>
	<AnalysisMode>AllEnabledByDefault</AnalysisMode>

Due to this regression: #6245, CAxxxx rules are no longer being bulk escalated to warning/error. I am going to work on a PR to pull in the latest NetAnalyzers package in the repo to first fix this and also the new violations that come out of it. I am going to block your PR #6367 until this work is done.

[mavasani]

@Youssef1313 This also explains why #6339 had no new violations.

[mavasani]

@Youssef1313 This also explains why #6339 had no new violations.

Moving to latest pre-release NetAnalyzers package produces 410 CA warnings!!

[mavasani]

Closing in favor of #6380