Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rulesets #6367

Merged
merged 6 commits into from
Dec 26, 2022
Merged

Remove rulesets #6367

merged 6 commits into from
Dec 26, 2022

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Dec 16, 2022 •
edited
Loading

Fixes #6365

@Youssef1313 Youssef1313 requested a review from a team as a code owner December 16, 2022 14:23
@codecov
Copy link

codecov bot commented Dec 16, 2022 •
edited
Loading

Codecov Report

Merging #6367 (90809ca) into main (460a0e5) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 90809ca differs from pull request most recent head 0386078. Consider uploading reports for the commit 0386078 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6367      +/-   ##
==========================================
- Coverage   96.10%   96.10%   -0.01%     
==========================================
  Files        1361     1361              
  Lines      316034   316055      +21     
  Branches    10192    10203      +11     
==========================================
+ Hits       303738   303748      +10     
- Misses       9864     9874      +10     
- Partials     2432     2433       +1

mavasani added a commit to mavasani/roslyn-analyzers that referenced this pull request Dec 21, 2022
@mavasani
Test PR for dotnet#6367
84767a0 
Test PR for dotnet#6367 (comment)
@mavasani mavasani mentioned this pull request Dec 21, 2022
Closed
mavasani added a commit to mavasani/roslyn-analyzers that referenced this pull request Dec 21, 2022
@mavasani
Test PR for dotnet#6367
42fd3db 
Test PR for dotnet#6367 (comment)
mavasani added a commit that referenced this pull request Dec 21, 2022
@mavasani
Test PR for #6367
8680739 
Test PR for #6367
@mavasani mavasani mentioned this pull request Dec 21, 2022
Closed
mavasani
mavasani previously requested changes Dec 22, 2022
View reviewed changes
Copy link
Contributor

@mavasani mavasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked for now as per #6375 (comment)

@mavasani
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@mavasani
Copy link
Contributor

@Youssef1313 CI is now failing as expected. You may want to redo this PR from scratch.

@Youssef1313 Youssef1313 requested a review from mavasani December 22, 2022 09:23
@mavasani
Copy link
Contributor

@Youssef1313 Just wanted to confirm that you do see build warnings if you remove any entry in any one of the 3 globalconfig files that you added?

@Youssef1313
Copy link
Member Author

@Youssef1313 Just wanted to confirm that you do see build warnings if you remove any entry in any one of the 3 globalconfig files that you added?

Yes.

Removing CA1000 from NonShipping.globalconfig:

image

Removing CA1002 from Common.globalconfig:

image

Also the following shows there are violations in both shipping and non-shipping projects:

image

Removing CA1303 from Shipping.globalconfig:

image

@Youssef1313 Youssef1313 requested a review from mavasani December 25, 2022 18:16
mavasani
mavasani reviewed Dec 26, 2022
View reviewed changes
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Runtime/SpecifyCultureForToLowerAndToUpper.cs
@@ -51,7 +51,8 @@ protected override void InitializeWorker(CompilationStartAnalysisContext context

private static bool IsToLowerOrToUpper(string methodName)
{
return methodName == ToLowerMethodName || methodName == ToUpperMethodName;
// TODO: Compare symbols instead of method name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File a tracking issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got a PR for it already #6382

mavasani
mavasani reviewed Dec 26, 2022
View reviewed changes
src/Test.Utilities/Test.Utilities.csproj
Comment on lines 5 to +6
<NonShipping>true</NonShipping>
<IsShipping>false</IsShipping>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are we using NonShipping? Can you please file a separate issue to tracking consolidating NonShipping and IsShipping to a single property?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6388

@mavasani mavasani enabled auto-merge December 26, 2022 16:01
@Youssef1313 Youssef1313 mentioned this pull request Dec 26, 2022
Open
@mavasani mavasani merged commit bad1e3c into dotnet:main Dec 26, 2022
@github-actions github-actions bot added this to the vNext milestone Dec 26, 2022
@Youssef1313 Youssef1313 deleted the cleanup-rulesets branch December 26, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mavasani mavasani mavasani approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.

Move the repo to globalconfigs and remove rulesets
2 participants
@Youssef1313 @mavasani