Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using Peek Definition disabled decompilation for that type #25731

Closed
jmarolf opened this issue Mar 26, 2018 · 1 comment · Fixed by #27940
Closed

Using Peek Definition disabled decompilation for that type #25731

jmarolf opened this issue Mar 26, 2018 · 1 comment · Fixed by #27940
Assignees
@sharwell
Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Milestone
15.8

Comments

@jmarolf
Copy link
Contributor

jmarolf commented Mar 26, 2018

Version Used: Visual Studio 2017.7 Preview 3 [27526.1.d15.7]

Steps to Reproduce:

  1. Peek Definition on a type defined in metadata
  2. Notice that the metadata type is not decompiled in to source
  3. Use Go To Definition

Expected Behavior:
Navigated to decompiled sources

Actual Behavior:
Navigated to metadata as source
@jcouv jcouv added the Area-IDE label Mar 27, 2018
@sharwell
Copy link
Member

sharwell commented Apr 3, 2018

Closely related to #23480

@jinujoseph jinujoseph added this to the Unknown milestone Apr 20, 2018
sharwell added a commit to sharwell/roslyn that referenced this issue Jun 17, 2018
@sharwell
Cache decompiled sources separately from metadata sources
022581c 
Fixes dotnet#25244
Fixes dotnet#25731
Fixes dotnet#27187
@sharwell sharwell mentioned this issue Jun 17, 2018
Merged
@sharwell sharwell added Bug 4 - In Review A fix for the issue is submitted for review. labels Jun 17, 2018
@sharwell sharwell self-assigned this Jun 17, 2018
@sharwell sharwell modified the milestones: Unknown, 15.8 Jun 17, 2018
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed 4 - In Review A fix for the issue is submitted for review. labels Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
Area-IDE Bug Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
15.8
Development

Successfully merging a pull request may close this issue.

Treat decompiled sources separately from metadata sources sharwell/roslyn
4 participants
@sharwell @jmarolf @jinujoseph @jcouv