Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable DocumentationComment tests skipped due to inferred indentation overriding UseTabs option #39967

Closed
mavasani opened this issue Nov 22, 2019 · 0 comments · Fixed by #40315
Closed

Re-enable DocumentationComment tests skipped due to inferred indentation overriding UseTabs option #39967

mavasani opened this issue Nov 22, 2019 · 0 comments · Fixed by #40315
Assignees
@jasonmalinowski
Labels
Area-IDE Test Test failures in roslyn-CI
Milestone
16.5

Comments

@mavasani
Copy link
Contributor

mavasani commented Nov 22, 2019 •
edited
Loading

See #39914 (comment) for details

Skipped tests:

  1. Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.DocumentationComments.DocumentationCommentTests.TestPressingEnter_Indentation5_UseTabs
  2. Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.DocumentationComments.DocumentationCommentTests.TestOpenLineBelow4_Tabs
  3. Microsoft.CodeAnalysis.Editor.VisualBasic.UnitTests.DocumentationComments.DocumentationCommentTests.TestOpenLineAbove4_Tabs
  4. Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.DocumentationComments.DocumentationCommentTests.TestOpenLineAbove4_Tabs
  5. Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.DocumentationComments.DocumentationCommentTests.TestOpenLineBelow4_Tabs
  6. Microsoft.CodeAnalysis.Editor.CSharp.UnitTests.DocumentationComments.DocumentationCommentTests.PressingEnter_Indentation5_UseTabs
@mavasani mavasani added Area-IDE Test Test failures in roslyn-CI labels Nov 22, 2019
@mavasani mavasani mentioned this issue Nov 22, 2019
Merged
mavasani added a commit to mavasani/roslyn that referenced this issue Nov 22, 2019
@mavasani
Skip unit tests failing due to inferred indentation with dotnet#39967
e0e5ea3
@jinujoseph jinujoseph added this to the 16.5 milestone Dec 4, 2019
jasonmalinowski added a commit to jasonmalinowski/roslyn that referenced this issue Dec 11, 2019
@jasonmalinowski
Unskip tests that were skipped due to adaptive formatting triggering
165dea1 
We had tests that set "use tabs" but then were working in a file of
mostly spaces. The editor behavior now is to treat this as if the
file had the "use spaces" on. I alternatively could have chosen to
disable inferrence, but then it seems we're not actually testing the
more mainline scenario of somebody having tabs in the entire file, which
seems like it's worth testing over odd mixed cases.

Closes dotnet#39967
@jasonmalinowski jasonmalinowski mentioned this issue Dec 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmalinowski jasonmalinowski

Labels
Area-IDE Test Test failures in roslyn-CI
Projects
None yet
Milestone
16.5
Development

Successfully merging a pull request may close this issue.

Unskip tests that were skipped due to adaptive formatting triggering jasonmalinowski/roslyn
3 participants
@jasonmalinowski @mavasani @jinujoseph