Unskip tests that were skipped due to adaptive formatting triggering #40315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had tests that set "use tabs" but then were working in a file of mostly spaces. The editor behavior now is to treat this as if the file had the "use spaces" on. I alternatively could have chosen to disable inferrence, but then it seems we're not actually testing the more mainline scenario of somebody having tabs in the entire file, which seems like it's worth testing over odd mixed cases. Closes dotnet#39967
mavasani
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had tests that set "use tabs" but then were working in a file of mostly spaces. The editor behavior now is to treat this as if the file had the "use spaces" on. I alternatively could have chosen to disable inferrence, but then it seems we're not actually testing the more mainline scenario of somebody having tabs in the entire file, which seems like it's worth testing over odd mixed cases.
Closes #39967
WARNING: this PR contains changes to leading whitespace in files. Checking "Hide whitespace changes" in GitHub is going to result in an incorrect diff.