Arcade bootstrapper: msbuildEngine, InitializeBuildTool #31446
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use more of Arcade bootstrapper functions. Convert buildCoreClr to msbuildEngine parameter used by Arcade. Update Initialize* functions to memoize their result.
|
@jaredpar PTAL |
jaredpar
reviewed
Nov 30, 2018
| # Used by tests to locate dotnet CLI | ||
| $env:DOTNET_INSTALL_DIR = Split-Path $dotnet -Parent | ||
| # Tests need to locate .NET Core SDK | ||
| InitializeDotNetCli |
There was a problem hiding this comment.
Where is this defined?
NM found it.
There was a problem hiding this comment.
This function returns a value and hence needs to be explicitly ignored. Otherwise you're adding an implicit return to Test-XUnit which should not have a return.
In reply to: 237947487 [](ancestors = 237947487)
|
Superseded by #31511 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use more of Arcade bootstrapper functions.
Convert
buildCoreClrtomsbuildEngineparameter used by Arcade.Update Initialize* functions to memoize their result.