Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arcade build scripts #31511

Merged
merged 9 commits into from
Dec 6, 2018
Merged

Arcade build scripts #31511

merged 9 commits into from
Dec 6, 2018

Conversation

tmat
Copy link
Member

@tmat tmat commented Dec 4, 2018

Use more of Arcade bootstrapper functions.
Convert buildCoreClr to msbuildEngine parameter used by Arcade.
Update Initialize* functions to memoize their result.

Use build.ps1 only for builds that follow standard build pipeline structure (restore, build, pack, test, sign, publish). Add a separate script for testing determinism and move common functions down to build-utils.ps1.

Use standard build pipeline from Arcade (build.proj).

Change build.sh to match build.ps1 wherever possible.

@tmat tmat requested a review from a team as a code owner December 4, 2018 02:12
@tmat tmat changed the title Arcade build scripts WIP: Arcade build scripts Dec 4, 2018
@tmat tmat force-pushed the ArcadeBuildScripts branch from 40aec3a to 1c3f986 Compare December 4, 2018 02:49
@tmat tmat force-pushed the ArcadeBuildScripts branch from 489ea1f to 0724a9f Compare December 4, 2018 22:10
@tmat tmat changed the title WIP: Arcade build scripts Arcade build scripts Dec 4, 2018
@tmat
Copy link
Member Author

tmat commented Dec 4, 2018

@jaredpar PTAL

.gitignore Show resolved Hide resolved
build/scripts/build.ps1 Outdated Show resolved Hide resolved
Copy link
Member

@jaredpar jaredpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tmat tmat merged commit 3f960f4 into dotnet:master Dec 6, 2018
@tmat tmat deleted the ArcadeBuildScripts branch December 6, 2018 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants