Merge 'dotnet/master' into DefaultInterfaceImplementation #34513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assumes.Present produces a more informative exception and message on failure.
* Require a single IStreamingFindUsagesPresenter * Link to debugger team (owner) in source control
Credit to @jasonmalinowski for suggesting this improvement
Cleanup project and solution
* Move EnC debug information reading to Features. Encapsulate the logic in EditAndContinueMethodDebugInfoReader.
…assed to a method (dotnet#34177) * Fixes dotnet#34176 * Fix test name * Update tests - WIP * Fix conditional * Improve conditional * add tests and check for caret before string
…structors (dotnet#34041) * Fixes 33603 and 33623 * Respond to feedback * Fix spelling/random characters Co-Authored-By: chborl <chborl@users.noreply.github.com> * Use IsEmpty property Co-Authored-By: chborl <chborl@users.noreply.github.com> * remove unneeded null check * Configure await false Co-Authored-By: chborl <chborl@users.noreply.github.com> * refactor null check Co-Authored-By: chborl <chborl@users.noreply.github.com> * Respond to feedback and refactor * Wrap long lines * Update test comments Co-Authored-By: chborl <chborl@users.noreply.github.com> * Change .AsImmutableOrNull to .ToImmutableAndFree Co-Authored-By: chborl <chborl@users.noreply.github.com> * Fix test doc comments * Apply suggestions from code review Update doc comment Co-Authored-By: chborl <chborl@users.noreply.github.com>
* made light bulb to check workspace status service * rename field name * addressing PR feedbacks * LB created more implementation than I needed * add tracking issues.
Update infrastructure for 16.1 preview1
Co-Authored-By: ryzngard <ryzngard@live.com>
Move checks in build.ps1 into try/catch block
* Analyze nullability in script initializer * C# 8 for scripts for now * nullable context script test * extra null check * added possibility to set c# Language Version on ScriptOptions * adjust tests * added ScriptOptionsTests for C# lang version * adapted tests after rebase * code review changes * fixed test names & resx CDATA * changed the ScriptOptions.WithLanguageVersion error message text and moved it to ScriptingResources.resx * Update CSharpScriptingResources.Designer.cs
Track l-values in conditional operator Assignment to ref variable produces safety warnings
Do not return null task In RemoveHostClientExtensions
Run CI on dev16.1-preview1 branches
We previously decided to remove IFromIndexOperation in favor of using an IUnaryOperation to represent the ^ syntax in C#, but did not have time to remove the interface completely. This PR finishes the change.
…o-master Merge dev16.1-preview1 to master
* removed IEditorClassificationService that is marked obsolete since 2017 and bunch of other code that only existed for the IEditorClassificationService. according to vso, only F# still has dependency so I talked to them to move to new API (IClassificationService) - https://devdiv.visualstudio.com/DevDiv/_git/DotNet-Source-Build-Tarball?path=%2Fsrc%2Ffsharp%2Fvsintegration%2Fsrc%2FFSharp.Editor%2FClassification%2FColorizationService.fs&version=GBmaster and a bunch of clean up and move code that has no dependency to the editor to lower layers so that I can consume in razor scenario. * added shim project for FSharp that has internal visible to FSharp editor * merged dotnet#31941 * addressing PR feedback * moved some type (such as DocumentSpan, ClassifiedSpan and etc) back to where fsharp has IVT to. can't move those since partner team is using them and they don't have IVT to workspace layer for some reasons. also, have put the IEditorClassificationService back and add a proxy in FSharp External Access so that it can still work until they remove all IVT.
AlekseyTs
added
Area-Compilers
Feature - Default Interface Impl
|
@dotnet/roslyn-compiler Need a sign-off for an integration PR |
RikkiGibson
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.