Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Document load failures (#40044)" #40302

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Revert "Document load failures (#40044)" #40302

merged 1 commit into from
Dec 12, 2019

Conversation

RikkiGibson
Copy link
Contributor

This reverts commit 6ac8006.

@RikkiGibson RikkiGibson requested a review from a team December 11, 2019 19:15
@RikkiGibson
Copy link
Contributor Author

FYI @ryzngard once we are sure from the test insertion that #40044 caused the DDRIT failure we should merge this and flow it through. Also, this is blocked on the broken license/cla check.

@RikkiGibson RikkiGibson marked this pull request as ready for review December 12, 2019 02:42
@RikkiGibson RikkiGibson requested a review from a team as a code owner December 12, 2019 02:42
@RikkiGibson RikkiGibson merged commit 10ccd1b into master Dec 12, 2019
@RikkiGibson
Copy link
Contributor Author

FYI @tmat it seems that PR #40044 was breaking DDRITs

@RikkiGibson RikkiGibson deleted the revert-40044-WorkspaceDiagnostics2 branch December 12, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzngard ryzngard ryzngard approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RikkiGibson @ryzngard