Pass in the "isGeneratedCode" flag from editorconfig options into syn… #40330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tax tree parse APIs in command line compiler and IDE syntax tree factory service. Builds on top of dotnet#39051 Addresses dotnet#3705
There was a problem hiding this comment.
Everything looks good except for the test: it seems like it's testing all the compiler or Workspace implementation APIs directly and thus not really testing the Workspace itself. For example, I wouldn't expect a test to be directly calling the syntax tree factories unless they're doing some specific memory testing around them. Seems like a better end-to-end test exists using the public APIs only like our other .editorconfig tests.
...Workspaces/Core/Portable/GeneratedCodeRecognition/AbstractGeneratedCodeRecognitionService.cs
Show resolved
Hide resolved
src/Workspaces/VisualBasic/Portable/LanguageServices/VisualBasicSyntaxTreeFactoryService.vb
Show resolved
Hide resolved
…d-code' into ConsumeGeneratedCodeApi
mavasani
commented
Dec 14, 2019
|
@dotnet/roslyn-compiler This is ready for review. Thanks! |
cston
reviewed
Dec 16, 2019
src/Compilers/Core/Portable/InternalUtilities/GeneratedCodeUtilities.cs
Outdated
Show resolved
Hide resolved
cston
reviewed
Dec 16, 2019
src/Compilers/Core/Portable/DiagnosticAnalyzer/AnalyzerDriver.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Dec 16, 2019
|
All CI passed. Overriding checks to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tax tree parse APIs in command line compiler and IDE syntax tree factory service and IGeneratedCodeRecognitionService.
Builds on top of #39051
Addresses #3705