Merge master into features/editorconfig-generated-code #40363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip analyzers in all CI builds except correctness
…ak for TS and F# Recent PR dotnet#39699 introduced a breaking API and functionality change for TypeScript and F# as they are using our internal option ClosedFileDiagnostics for controlling their full solution analysis experience. This PR restores the ClosedFileDiagnostics option and functionality for non C#/VB languages. Additionally, the newly added option SolutionCrawlerOptions.BackgroundAnalysisScope has been made a per-language option so that all languages can have different UI/setting for this option.
…s-deps Merge master to master-vs-deps
Re-add ServiceFeatureOnOffOptions.ClosedFileDiagnostic to fix the bre…
Update FormattingDiagnosticIds.cs
…rator.cs Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
…slyn into genHashCodeVar
…er-to-master-vs-deps
…s-deps Merge master to master-vs-deps
Properly respect 'var' settings when generating equals/GetHashCode
…operty as a configuration change that needs to kick off re-analysis. Verified that added unit tests fail before the fix.
…spectRunAnalyzers Ensure that work coordinator sees change to "RunAnalyzers" project pr…
dotnet#39955 re-added the option back to Workspaces instead of Features, its original location
Fix a false positive in IDE0059 in presence of try/finally
…gnostics2 Revert "Document load failures (dotnet#40044)"
…n-lightup Remove reflection-based lightup of IIndentationManagerService
Binding with ElementName requires that an x:Name property be specified that relates to the given name. Binding uses a lookup order to find the names available by querying above the current element, which won't have the property yet. System.Windows.Data Warning: 70 : BindingExpression (hash=17108371): Found data context element: <null> (OK) System.Windows.Data Warning: 74 : Lookup name ThisPane: queried Border (hash=10270353) System.Windows.Data Warning: 74 : Lookup name ThisPane: queried LightBulbMenuItem (hash=49364328) System.Windows.Data Error: 4 : Cannot find source for binding with reference 'ElementName=ThisPane'. BindingExpression:Path=AutomationName; DataItem=null; target element is 'PreviewPane' (Name='ThisPane'); target property is 'Name' (type 'String') Fix by using self as a relative source instead of ElementName
Add codefix for CS0708
…unctionBug Fix for introduce local does not introduce across local functions
…ne if elementNullableAnnotations is default array. (dotnet#40348) Fixes dotnet#40105.
JoeRobich
approved these changes
Dec 14, 2019
|
Thanks @JoeRobich! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to resolve the integration test failures in this feature branch. See #40330