Merge master to features/covariant-returns #43723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method uses Optional<T> instead of T for the return value of TryDequeueAsync, allowing the method to support normal termination of the queue without throwing cancellation exceptions.
…tEditSpan and GetReferenceEditSpan
…mbols for tuple underlying fields. (dotnet#43552) Fixes dotnet#43524. Related to dotnet#43549. Also, ensure nested type is generated for a fixed size buffer declared within a tuple type. Related to dotnet#43621.
Add overload for rpc that can work on streams, not just object writers.
This makes the following changes to our ability to build the current project from VSCode (essentially implementing the rough equivalent of build current project in VS). - Ability to choose `msbuild` in addition to `dotnet msbuild`. The full framework `msbuild` is still necessary for building parts of the IDE code base. - Support for VB projects - Fixes the execution of the task on Windows. The hard dependency on `/.dotnet` existing doesn't hold on Windows. Falling back to normal powershell in that environment
🐇 Avoid computing unnecessary semantic models
Support a single OOP call to perform all of rename, on top of the individual pieces of rename that are already OOPed
Co-Authored-By: Rikki Gibson <rikkigibson@gmail.com>
Improve VS Code build current project support
…deDiagnosticAnalyzer.cs
Don't offer to use System.HashCode when the existing GetHashCode is already simple enough.
Don't remove null-casts in switch expressions
…ionsTSRename Update inline rename code following completion of TypeScript external access work
…ant-returns-merge-2020-04-27
gafter
added
Area-Compilers
Feature - Covariant Returns
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.