Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceHub core host integration test CI #57228

Merged
merged 4 commits into from
Oct 22, 2021

Conversation

genlu
Copy link
Member

@genlu genlu commented Oct 19, 2021

This depends on the change in #57223

azure-pipelines-integration-corehost.yml Show resolved Hide resolved
pool:
name: NetCorePublic-Pool
queue: $(queueName)
timeoutInMinutes: 135
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a matrix so we test both Release and Debug configurations. See example

- job: VS_Integration
pool:
name: $(poolName)
queue: $(queueName)
strategy:
maxParallel: 4
matrix:
debug_32:
_configuration: Debug
_oop64bit: false
debug_64:
_configuration: Debug
_oop64bit: true
release_32:
_configuration: Release
_oop64bit: false
release_64:
_configuration: Release
_oop64bit: true
timeoutInMinutes: 135
steps:
- template: eng/pipelines/test-integration-job.yml
parameters:
configuration: $(_configuration)
oop64bit: $(_oop64bit)
lspEditor: false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use $(poolName) in this new leg as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That isn't necessary. We use that for our scouting queue.

genlu and others added 2 commits October 21, 2021 14:30
Co-authored-by: Joey Robichaud <joseph.robichaud@microsoft.com>
@genlu
Copy link
Member Author

genlu commented Oct 22, 2021

@JoeRobich The new CI pipeline seems to be working as expected.
https://dev.azure.com/dnceng/public/_build/results?buildId=1436555&view=ms.vss-test-web.build-test-results-tab&runId=41474486&resultId=100409&paneView=debug

Should I go ahead and merge this? How can I make sure the new core host legs are not blocking PRs?

@genlu genlu enabled auto-merge October 22, 2021 22:15
@genlu
Copy link
Member Author

genlu commented Oct 22, 2021

@JoeRobich Merge is blocked by flaky integration tests. Could you force merge this please? I believe the change in shared files is validated by (failed) integration test runs. Thanks!

@JoeRobich JoeRobich disabled auto-merge October 22, 2021 23:35
@JoeRobich JoeRobich merged commit 145752d into dotnet:main Oct 22, 2021
@ghost ghost added this to the Next milestone Oct 22, 2021
@genlu genlu deleted the OopCoreIntegrationTest branch October 22, 2021 23:38
@genlu
Copy link
Member Author

genlu commented Oct 22, 2021

Thanks! @JoeRobich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants