Add MS.CA.CSharp.Workspaces and MS.CA.VB.Workspaces as VSIX analyzer … #57294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assets Fixes dotnet#57293 With recent changes to move OOP to .NET Core, we seem to require specifying analyzer dependencies as analyzer assets. dotnet@6c7f97b added MS.CA.Workspaces as an asset, this change extends it to add the C# and VB Workspaces assemblies as analyzer assets.
|
Tagging @jinujoseph @vatsalyaagrawal for visibility NOTE: Without this change, all our IDE analyzers that reference CSharpCodeStyleOptions or VisualBasicCodeStyleOptions in their constructor will fail to load, we have large number of such analyzers in our codebase. |
|
@genlu Will probably need your help here, seeing the following build time failure in integration test runs: |
|
Thank you @JoeRobich |
mavasani
commented
Oct 21, 2021
| } | ||
| "); | ||
| VisualStudio.Editor.InvokeCodeActionList(); | ||
| VisualStudio.Editor.Verify.CodeAction("Unnecessary assignment of a value to 'x'"); |
genlu
approved these changes
Oct 21, 2021
genlu
reviewed
Oct 21, 2021
| @@ -84,6 +84,26 @@ class Program | |||
| VisualStudio.Editor.Verify.CodeAction("using System;"); | |||
| } | |||
|
|
|||
| [WpfFact, Trait(Traits.Feature, Traits.Features.CodeActionsRemoveUnusedValues)] | |||
| [WorkItem(57293, "https://github.com/dotnet/roslyn/issues/57293")] | |||
| public void RemoveRedundantAssignmentCodeFix() | |||
There was a problem hiding this comment.
Just want to point out that this change is required at the moment to cover Core host sceanrios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…assets
Fixes #57293
With recent changes to move OOP to .NET Core, we seem to require specifying analyzer dependencies as analyzer assets. 6c7f97b added MS.CA.Workspaces as an asset, this change extends it to add the C# and VB Workspaces assemblies as analyzer assets. These assemblies define CSharpCodeStyleOptions and VisualBasicCodeStyleOptions types, which are used in ctors of many of our analyzers.