Corrected documentation on FullSpan and Span #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
|
I agree this LGTM. Once we are in a position to merge code based PR's this will be merged in. |
|
Wow, thos are some misleading doc comments 😄 |
theoy
added
Concept-API
|
👍 |
|
@JoshVarty can you sign the following please if you haven't already? That will allow us to merge this in once we flip the switch this weekend. At some point next week this process will become automated and won't need me posting messages to make it happen 😄 |
|
Done ✔️ |
jaredpar
added a commit
that referenced
this pull request
Feb 9, 2015
Corrected documentation on FullSpan and Span
OmarTawfik
added a commit
that referenced
this pull request
May 18, 2017
* Call this.DeclaringCompilation.EnsureReadOnlyAttributeExists() when needed * Promote EmbeddedAttribute to be used by both compilers * Generate Embedded attributes on PE Module Builder * Thread PEModuleBuilder through Symbol.AddSynthesizedAttributes() * Fix failing tests * Base case passing * Refactor ReadOnlyAttribute to IsReadOnlyAttribute * Fix build break * More Tests * Clean up * PR Comments #1 PR Comments #3 PR Comments #4 PR Comments #5 PR Comments #6 PR Comments # 7 * Handle NoPIA Added more tests * Lambdas and Local functions no longer generate attributes in symbols Added tests for constructors and operators Signal need for synthesized attributes in local rewriter for lambdas an local functions Clean up * Clean up * More PR Feedback * Adding more tests * More PR Comments * More tests for explicit interface implementations * Latest PR Comments * Moved EnsureIsReadOnlyAttributeExists to AfterAddingTypeMembersChecks * Fix failing tests
Cosifne
added a commit
that referenced
this pull request
Feb 19, 2021
Support multiple positions in AutomaticLineEnderTests
AlekseyTs
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the Incorrect Docs on FullSpan/Span properties issue, the documentation was reversed on a few of these pairs.