Skip to content

Commit

Permalink
[release/8.0-rc1] [mono] Fix InlineArray tests on android platforms (#…
Browse files Browse the repository at this point in the history
…90679)

* Enable inline array tests

* Run android jobs only

* Add verbose logging

* Revert runtime changes

* Remove android-arm64 job

* Rename common assembly and revert CI changes

* Rename assembly name

---------

Co-authored-by: Milos Kotlar <kotlarmilos@gmail.com>
  • Loading branch information
github-actions[bot] and kotlarmilos authored Aug 16, 2023
1 parent 7cc25f5 commit c96e5ab
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<Compile Include="InlineArrayInvalid.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="InvalidCSharp.ilproj" />
<ProjectReference Include="InvalidCSharpInlineArray.ilproj" />
<ProjectReference Include="$(TestSourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<Compile Include="InlineArrayValid.cs" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="InvalidCSharp.ilproj" />
<ProjectReference Include="InvalidCSharpInlineArray.ilproj" />
<ProjectReference Include="$(TestSourceDir)Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
</ItemGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

.assembly extern System.Runtime { .publickeytoken = (B0 3F 5F 7F 11 D5 0A 3A ) }

.assembly InvalidCSharp { }
.assembly InvalidCSharpInlineArray { }

.class public explicit ansi sealed beforefieldinit Explicit
extends [System.Runtime]System.ValueType
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
<OutputType>Library</OutputType>
</PropertyGroup>
<ItemGroup>
<Compile Include="InvalidCSharp.il" />
<Compile Include="InvalidCSharpInlineArray.il" />
</ItemGroup>
</Project>
3 changes: 0 additions & 3 deletions src/tests/issues.targets
Original file line number Diff line number Diff line change
Expand Up @@ -3482,9 +3482,6 @@
<ExcludeList Include = "$(XunitTestBinBase)/Loader/classloader/StaticVirtualMethods/GenericContext/**">
<Issue>https://github.com/dotnet/runtime/issues/67359</Issue>
</ExcludeList>
<ExcludeList Include="$(XunitTestBinBase)/Loader/classloader/InlineArray/**">
<Issue>https://github.com/dotnet/runtime/issues/90398</Issue>
</ExcludeList>
</ItemGroup>

<ItemGroup Condition="'$(TargetOS)' == 'android' And '$(TargetArchitecture)' == 'arm64'">
Expand Down

0 comments on commit c96e5ab

Please sign in to comment.