[release/8.0-rc1] [mono] Fix InlineArray tests on android platforms #90679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
kotlarmilos
added
Servicing-consider
|
Tagging subscribers to this area: @directhex Issue DetailsBackport of #90583 to release/8.0-rc1 /cc @kotlarmilos Customer ImpactTestingRiskIMPORTANT: If this backport is for a servicing release, please verify that:
|
lewing
approved these changes
Aug 16, 2023
carlossanlop
added
Servicing-approved
|
CI failure is known: |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #90583 to release/8.0-rc1
This PR enables class loader runtime tests on android platforms on the CI.
Runtime tests for mobile targets are grouped into bundles, where each bundle contains multiple entry points. All assemblies are copied to the root directory of a given bundle on android platforms, meaning if two or more assemblies within one test group have the same names, one will overwrite the other, which could potentially lead to runtime errors.
The fix for this issue, an assembly is renamed to be unique in the test app bundle.
Customer Impact
The issue was discovered by a team member.
Testing
Manual testing and automated testing on the CI were performed, ensuring that the tests are passing on android platforms. The issue has been reproduced locally, and has been fixed.
Risk
Low risk. This change enables class loader runtime tests on android platforms on the CI.
The change doesn't affect code that ships in a NuGet package.