-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[wasm] Download Symbols from microsoft symbol server (#40690)
* Creating a draft to download symbols from microsoft symbol server when there is an exception and exceptions are turned on on debugger. This is a workaround while VS doesn't work on it, which should be the final solution. * Fix what lewing suggested. * Changing what @radical suggested. * Changed what @radical suggested. * Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs Co-authored-by: Ankit Jain <radical@gmail.com> * Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs Co-authored-by: Ankit Jain <radical@gmail.com> * If it's not available on a URL try in the next one in the list. * Logging error and adding comment about SDSR * Returning if we find the method even if we have an exception sending files to browser. * Logging when we don't find the pdb. * Changing what @radical suggested. * Avoiding that we try to load symbols from the same assembly more than once. * Simplifying and adding more log. * Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs Co-authored-by: Larry Ewing <lewing@microsoft.com> * Adding support for receive the urlSymbolServer as a parameter in the request as discussed with Diego: Diego: The response from vs code is that this shouldn't live in js-debug, so I think that passing it around in inspectUri would be the best approach for us * Fix @radical suggestion. * Removing default symbol server URL, like this we can land this on rc 5.0 without any risk of side effect. * Fix compilation. * Update src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessStartup.cs Co-authored-by: Ankit Jain <radical@gmail.com> * Update src/mono/wasm/debugger/BrowserDebugHost/Startup.cs Co-authored-by: Ankit Jain <radical@gmail.com> * Accepting @radical suggestion. * Adding workaround on dotnet/runtime while PR 686 is not merged on Cecil. When it's merged we will not get any side effect with this workaroud. Co-authored-by: Ankit Jain <radical@gmail.com> Co-authored-by: Larry Ewing <lewing@microsoft.com>
- Loading branch information
1 parent
67fd47e
commit eb6bcde
Showing
5 changed files
with
135 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters