[wasm] Download Symbols from microsoft symbol server

[thaystg]

Creating a draft to download symbols from microsoft symbol server when there is an exception and exceptions are turned on on debugger.

This is a workaround while VS doesn't work on it, which should be the final solution.

If you think that is in the right way, there is still a to do list:

• Read url from config file, or receive as an startup parameter.
• Create a flag to enable and disable this functionality, because this may cause some slowness when creating the callstack of the exception.

The callstack exception without this PR:

The callstack exception with this PR:

[thaystg]

I'm not sure what is the best way to receive the symbol server url, I was thinking to receive in the same way that we receive browserUri, and pass to DevToolsProxy in run method. If anyone has any better idea, please let me know.

[radical]

Only nitpicks, nothing to block merging. 👍

[radical]

I'm not sure what is the best way to receive the symbol server url, I was thinking to receive in the same way that we receive browserUri, and pass to DevToolsProxy in run method. If anyone has any better idea, please let me know.

What does the server url depend on? Does it change?

[thaystg]

I'm not sure what is the best way to receive the symbol server url, I was thinking to receive in the same way that we receive browserUri, and pass to DevToolsProxy in run method. If anyone has any better idea, please let me know.

What does the server url depend on? Does it change?

On VsWindows for example, the user can choose a list of symbol server URL. From Microsoft I think that this is the only one.

[radical]

re:url, you could send a custom message to the proxy to pass the url, and handle that in MonoProxy, similar to https://github.com/dotnet/runtime/blob/master/src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs#L340-L341 . We send that one in tests - https://github.com/dotnet/runtime/blob/master/src/mono/wasm/debugger/DebuggerTestSuite/Support.cs#L878 .

How will you get this url from VS though, to pass on to the proxy?

[thaystg]

The custom message that you suggested is the same that I think we should do.
I have no idea how to get this url from VS, but if we create the custom message, VS team can call this message passing to Proxy the urls.

[thaystg]

@lewing , I'm discussing with Diego about how they will pass this info for DebuProxy.

[thaystg]

@lewing @radical now this is ready to be merged.
Diego asked to pass the urlSymbolServer as a parameter, like this they don't need to change js-debug. In any case, I let the protocol extension if we need this later and accept the parameter too.

[radical]

Is there anything blocking this now?

[thaystg]

I don't think so, I just removed the default microsoft symbol server URL, then we can try to merge it on rc 2.
@lewing can we merge now?

[thaystg]

@lewing I removed the default URL of MS Symbol Server, so now, this will not affect the user unless he changes the LaunchSettings.json to use this InspectUri: "inspectUri": "{wsProtocol}://{url.hostname}:{url.port}/_framework/debug/ws-proxy?browser={browserInspectUri}?urlSymbolServer=http://msdl.microsoft.com/download/symbols"
Then the new implementation will be effective.

[thaystg]

/backport to release/5.0-rc2

[github-actions]

Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/256085151