Remove all uses of SString::Printf() accepting WCHAR (#76571)

* Remove uses of SString::Printf(const WCHAR*, ...) * Remove SString::Printf(const WCHAR*, ...) * Remove unused dbg event redirection logic
dotnet · Oct 5, 2022 · fec0221 · fec0221
1 parent 588fa49
commit fec0221
Show file tree

Hide file tree

Showing 32 changed files with 171 additions and 904 deletions.
diff --git a/src/coreclr/binder/bindertracing.cpp b/src/coreclr/binder/bindertracing.cpp
@@ -305,7 +305,9 @@ namespace BinderTracing
 
                 case FUSION_E_REF_DEF_MISMATCH:
                     result = Result::MismatchedAssemblyName;
-                    errorMsg.Printf(W("Requested assembly name '%s' does not match found assembly name"), m_assemblyName.GetUnicode());
+                    errorMsg.Append(W("Requested assembly name '"));
+                    errorMsg.Append(m_assemblyName.GetUnicode());
+                    errorMsg.Append(W("' does not match found assembly name"));
                     if (resultAssembly != nullptr)
                     {
                         errorMsg.Append(W(" '"));
@@ -325,7 +327,7 @@ namespace BinderTracing
                     else
                     {
                         result = Result::Failure;
-                        errorMsg.Printf(W("Resolution failed with HRESULT (%08x)"), m_hr);
+                        errorMsg.Printf("Resolution failed with HRESULT (%08x)", m_hr);
                     }
             }
         }

diff --git a/src/coreclr/binder/textualidentityparser.cpp b/src/coreclr/binder/textualidentityparser.cpp
@@ -112,7 +112,7 @@ namespace BINDER_SPACE
             if (AssemblyIdentity::Have(dwIdentityFlags, AssemblyIdentity::IDENTITY_FLAG_VERSION))
             {
                 tmpString.Clear();
-                tmpString.Printf(W("%d.%d.%d.%d"),
+                tmpString.Printf("%d.%d.%d.%d",
                                  (DWORD)(USHORT)pAssemblyIdentity->m_version.GetMajor(),
                                  (DWORD)(USHORT)pAssemblyIdentity->m_version.GetMinor(),
                                  (DWORD)(USHORT)pAssemblyIdentity->m_version.GetBuild(),

diff --git a/src/coreclr/debug/di/CMakeLists.txt b/src/coreclr/debug/di/CMakeLists.txt
@@ -17,7 +17,6 @@ set(CORDBDI_SOURCES
   dbgtransportmanager.cpp
   hash.cpp
   module.cpp
-  nativepipeline.cpp
   platformspecific.cpp
   process.cpp
   rsappdomain.cpp

diff --git a/src/coreclr/debug/di/eventredirectionpipeline.cpp b/src/coreclr/debug/di/eventredirectionpipeline.cpp