Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all uses of SString::Printf() accepting WCHAR #76571

Merged
merged 9 commits into from
Oct 5, 2022
Merged

Remove all uses of SString::Printf() accepting WCHAR #76571

merged 9 commits into from
Oct 5, 2022

Conversation

AaronRobinsonMSFT
Copy link
Member

This removes all uses of the SString::Printf(const WCHAR* fmt, ...) from the VM code base. It is another step toward removing the custom wprintf logic from the PAL.

/cc @jkotas @janvorli @elinor-fung @jkoritzinsky

@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 8.0.0 milestone Oct 3, 2022
jkotas
jkotas reviewed Oct 3, 2022
View reviewed changes
src/coreclr/vm/typedesc.cpp Outdated Show resolved Hide resolved
src/coreclr/vm/nativelibrary.cpp Outdated Show resolved Hide resolved
src/coreclr/debug/di/eventredirectionpipeline.cpp Outdated Show resolved Hide resolved
@AaronRobinsonMSFT
Use char instead of char* overload
0a13284 
Fix format printing for nativelibrary loading
@AaronRobinsonMSFT AaronRobinsonMSFT marked this pull request as ready for review October 4, 2022 18:42
@AaronRobinsonMSFT
Copy link
Member Author

CI is green. Please take another look. Thanks.

jkotas
jkotas approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo comments

elinor-fung
elinor-fung approved these changes Oct 5, 2022
View reviewed changes
src/coreclr/vm/clrex.cpp Show resolved Hide resolved
@AaronRobinsonMSFT AaronRobinsonMSFT merged commit fec0221 into dotnet:main Oct 5, 2022
@AaronRobinsonMSFT AaronRobinsonMSFT deleted the update_sstring branch October 5, 2022 15:24
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@noahfalk noahfalk noahfalk left review comments

@janvorli janvorli janvorli left review comments

@tommcdon tommcdon tommcdon left review comments

@hoyosjs hoyosjs hoyosjs left review comments

@jkotas jkotas jkotas approved these changes

@elinor-fung elinor-fung elinor-fung approved these changes

@davidwrighton davidwrighton Awaiting requested review from davidwrighton

Assignees

@AaronRobinsonMSFT AaronRobinsonMSFT

Labels
area-VM-coreclr
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@AaronRobinsonMSFT @noahfalk @jkotas @janvorli @tommcdon @hoyosjs @elinor-fung