Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][globalization][tests] RegionInfoPropertyTests.DisplayName failures #45951

Closed
kjpou1 opened this issue Dec 11, 2020 · 5 comments
Closed

[browser][globalization][tests] RegionInfoPropertyTests.DisplayName failures #45951

kjpou1 opened this issue Dec 11, 2020 · 5 comments
Assignees
@ilonatommy
Labels
arch-wasm WebAssembly architecture area-System.Globalization
Milestone
8.0.0

Comments

@kjpou1
Copy link
Contributor

kjpou1 commented Dec 11, 2020 

[03:50:22] fail: [FAIL] System.Globalization.Tests.RegionInfoPropertyTests.DisplayName(name: "en-US", expected: "United States")
[03:50:22] info: Assert.Equal() Failure
[03:50:22] info:            ↓ (pos 1)
[03:50:22] info: Expected: United States
[03:50:22] info: Actual:   US
[03:50:22] info:            ↑ (pos 1)
[03:50:22] info:    at System.Globalization.Tests.RegionInfoPropertyTests.DisplayName(String name, String expected)
[03:50:22] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Found when executing the outerloop tests

[OuterLoop("May fail on machines with multiple language packs installed")] // see https://github.com/dotnet/runtime/issues/30132

See PR: #45949
@kjpou1 kjpou1 added arch-wasm WebAssembly architecture area-System.Globalization labels Dec 11, 2020
@ghost
Copy link

ghost commented Dec 11, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details 
[03:50:22] fail: [FAIL] System.Globalization.Tests.RegionInfoPropertyTests.DisplayName(name: "en-US", expected: "United States")
[03:50:22] info: Assert.Equal() Failure
[03:50:22] info:            ↓ (pos 1)
[03:50:22] info: Expected: United States
[03:50:22] info: Actual:   US
[03:50:22] info:            ↑ (pos 1)
[03:50:22] info:    at System.Globalization.Tests.RegionInfoPropertyTests.DisplayName(String name, String expected)
[03:50:22] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Found when executing the outerloop tests

[OuterLoop("May fail on machines with multiple language packs installed")] // see https://github.com/dotnet/runtime/issues/30132

See PR: #45949

Author: kjpou1
Assignees: -
Labels:

arch-wasm, area-System.Globalization
Milestone: -

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Dec 11, 2020
@kjpou1 kjpou1 removed the untriaged New issue has not been triaged by the area owner label Dec 11, 2020
kjpou1 added a commit that referenced this issue Jan 20, 2021
@kjpou1
[browser][tests][outerloop] Standup OuterLoop tests on CI (#45949)
c72b542 
* [browser][tests][outerloop] Standup OuterLoop tests on CI

* System.Collections.NonGeneric.Tests passing

* System.Console.Tests passing

* System.Diagnostics.DiagnosticSource.Tests passing

* System.Globalization.Tests passing

- See active issue #45951

* System.IO.FileSystem.Tests passing after deactivating test cannot wait on monitors on this runtime.

* System.IO.FileSystem.Tests passing - See active issue: #45954

* Remove fat fingered code.

* Threads not supported on Browser

* Browser does not support monitor

* Browser does not support monitor

* Browser does not support wait on monitors

* Browser does not support wait on monitors

* Add ActiveIssue for DataFlow tests TestNullTarget_CompletionNoCaching

* Add ActiveIssue for DataFlow tests

* Add ActiveIssue for DataFlow tests

* Add threading support conditional

* Change all Cannot wait on monitors on this runtime Browser platform checks to

[ConditionalXXXX(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))]

As was suggested in comments

* Address review comment for monitors not supported

* Address review comments

* Add threading supported condition.

```
fail: [FAIL] System.Text.Json.Serialization.Tests.EnumConverterTests.VeryLargeAmountOfEnumsToSerialize
[08:10:56] info: System.PlatformNotSupportedException : Cannot wait on monitors on this runtime.
```
@SamMonoRT SamMonoRT added this to the 6.0.0 milestone Jun 23, 2021
@SamMonoRT
Copy link
Member

@radical - is this still an issue we need to fix in .NET6?

@lewing lewing modified the milestones: 6.0.0, 7.0.0 Aug 4, 2021
@ilonatommy
Copy link
Member

ilonatommy commented Jun 14, 2022 •
edited
Loading

Neither on runfo nor locally (3 lang packs installed: en, pl, cs) I cannot see it failing anymore. Planning to remove the comment and close.
Edit: that's not true, tests were disabled all the time.

ilonatommy added a commit to ilonatommy/runtime that referenced this issue Jun 14, 2022
@ilonatommy
Removing - no failures described in dotnet#45951 happen anymore.
a909d3a
@ilonatommy ilonatommy mentioned this issue Jun 14, 2022
Closed
@ghost ghost added in-pr There is an active PR which will close this issue when it is merged and removed in-pr There is an active PR which will close this issue when it is merged labels Jun 14, 2022
@lewing
Copy link
Member

lewing commented Jul 25, 2022

This is related to what icu subsets are included

@ilonatommy ilonatommy mentioned this issue Jul 26, 2022
Closed
10 tasks
@ilonatommy ilonatommy modified the milestones: 7.0.0, 8.0.0 Aug 12, 2022
@ilonatommy
Copy link
Member

This is a duplicate of #44739. The same reason, just different ways to extract the shortened data.

@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-System.Globalization
Projects
None yet
Milestone
8.0.0
5 participants
@lewing @kjpou1 @ilonatommy @Dotnet-GitSync-Bot @SamMonoRT