-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser][io][tests] Failure: System.IO.Tests file for 2GB file reads #45954
Comments
Dotnet-GitSync-Bot
added
area-System.IO
untriaged
New issue has not been triaged by the area owner
labels
Dec 11, 2020
kjpou1
added
arch-wasm
WebAssembly architecture
and removed
untriaged
New issue has not been triaged by the area owner
labels
Dec 11, 2020
kjpou1
added a commit
that referenced
this issue
Jan 20, 2021
* [browser][tests][outerloop] Standup OuterLoop tests on CI * System.Collections.NonGeneric.Tests passing * System.Console.Tests passing * System.Diagnostics.DiagnosticSource.Tests passing * System.Globalization.Tests passing - See active issue #45951 * System.IO.FileSystem.Tests passing after deactivating test cannot wait on monitors on this runtime. * System.IO.FileSystem.Tests passing - See active issue: #45954 * Remove fat fingered code. * Threads not supported on Browser * Browser does not support monitor * Browser does not support monitor * Browser does not support wait on monitors * Browser does not support wait on monitors * Add ActiveIssue for DataFlow tests TestNullTarget_CompletionNoCaching * Add ActiveIssue for DataFlow tests * Add ActiveIssue for DataFlow tests * Add threading support conditional * Change all Cannot wait on monitors on this runtime Browser platform checks to [ConditionalXXXX(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))] As was suggested in comments * Address review comment for monitors not supported * Address review comments * Add threading supported condition. ``` fail: [FAIL] System.Text.Json.Serialization.Tests.EnumConverterTests.VeryLargeAmountOfEnumsToSerialize [08:10:56] info: System.PlatformNotSupportedException : Cannot wait on monitors on this runtime. ```
I've hit this limitation when I was working on #60459 earlier today. It seems that large files > 2 GB are simply not supported by WASM. Sample tests: [Fact]
public void LargeFilesAreSupported()
{
const long positon = int.MaxValue + 1L;
string filePath = GetTestFilePath();
byte[] data = { 1, 2, 3, 4, 5 };
using (var stream = new FileStream(filePath, FileMode.Create, FileAccess.Write))
{
stream.Seek(positon, SeekOrigin.Begin);
stream.Write(data);
Assert.Equal(positon + data.Length, stream.Position);
Assert.Equal(positon + data.Length, stream.Length);
}
} Fails with:
@SamMonoRT @lewing @vargaz are we aware of that? I am asking because the info provided above may suggest that only |
50 tasks
This comment was marked as outdated.
This comment was marked as outdated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
64 bit numbers could be the culprit here as it seems to stand out.
The tests are failing with the following:
See PR: #45949
The text was updated successfully, but these errors were encountered: