Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tvOS] Test failures in System.Diagnostics.Tracing.Tests #56073

Open
MaximLipnin opened this issue Jul 21, 2021 · 11 comments
Open

[tvOS] Test failures in System.Diagnostics.Tracing.Tests #56073

MaximLipnin opened this issue Jul 21, 2021 · 11 comments
Assignees
@mdh1418
Labels
area-System.Diagnostics.Tracing os-android os-ios Apple iOS
Milestone
Future

Comments

@MaximLipnin
Copy link
Contributor

  • BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity
<failure exception-type="Xunit.Sdk.NotEqualException">
    <message><![CDATA[Assert.NotEqual() Failure\nExpected: Not 00000000-0000-0000-0000-000000000000\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity()
    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync
<failure exception-type="Xunit.Sdk.NotEqualException">
    <message><![CDATA[Assert.NotEqual() Failure\nExpected: Not 00000000-0000-0000-0000-000000000000\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync
<failure exception-type="Xunit.Sdk.EqualException">
    <message><![CDATA[Assert.Equal() Failure\nExpected: ed27419e-317a-43a7-be88-6b793b146141\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync
<failure exception-type="Xunit.Sdk.EqualException">
    <message><![CDATA[Assert.Equal() Failure\nExpected: 33f1669b-7f05-46a8-bf4c-f321de6083f6\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>

cc @steveisok
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Jul 21, 2021
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@MaximLipnin
Copy link
Contributor Author

Those tests have been added recently in #55625. They are skipped for WASM, I'm not sure if we want to do the same for Apple mobile platforms.

This was referenced Jul 21, 2021
Merged
Closed
@ghost
Copy link

ghost commented Jul 21, 2021

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details
  • BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity
<failure exception-type="Xunit.Sdk.NotEqualException">
    <message><![CDATA[Assert.NotEqual() Failure\nExpected: Not 00000000-0000-0000-0000-000000000000\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity()
    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync
<failure exception-type="Xunit.Sdk.NotEqualException">
    <message><![CDATA[Assert.NotEqual() Failure\nExpected: Not 00000000-0000-0000-0000-000000000000\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync
<failure exception-type="Xunit.Sdk.EqualException">
    <message><![CDATA[Assert.Equal() Failure\nExpected: ed27419e-317a-43a7-be88-6b793b146141\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync
<failure exception-type="Xunit.Sdk.EqualException">
    <message><![CDATA[Assert.Equal() Failure\nExpected: 33f1669b-7f05-46a8-bf4c-f321de6083f6\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>

cc @steveisok

Author: MaximLipnin
Assignees: -
Labels:

area-System.Diagnostics.Tracing, untriaged
Milestone: -

@steveisok
Copy link
Member

@MaximLipnin Can you check to see what the value is for <EventSourceSupport> ?

@MaximLipnin
Copy link
Contributor Author

@steveisok Something close to the mobile targets is https://github.com/dotnet/runtime/blob/main/eng/testing/tests.mobile.targets#L26 but we don't set EAT for the staging lanes so perhaps EventSourceSupport is not set

@lateralusX
Copy link
Member

lateralusX commented Jul 21, 2021 •
edited
Loading

Do we build with diagnostics tracing component support enabled when running tests on mobile, link or deploy needed components? I guess this tests will end up in ves_icall_System_Diagnostics_Tracing_EventPipeInternal_EventActivityIdControl and if we don't have component support loaded that will be a nop operation so won't set thread activity ID and that will trigger the assert in this test.

@steveisok
Copy link
Member

I don't think we do. We probably should skip these for the time being.

@steveisok steveisok removed the untriaged New issue has not been triaged by the area owner label Jul 21, 2021
@ghost
Copy link

ghost commented Jul 21, 2021

Tagging subscribers to 'arch-android': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details
  • BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity
<failure exception-type="Xunit.Sdk.NotEqualException">
    <message><![CDATA[Assert.NotEqual() Failure\nExpected: Not 00000000-0000-0000-0000-000000000000\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity()
    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync
<failure exception-type="Xunit.Sdk.NotEqualException">
    <message><![CDATA[Assert.NotEqual() Failure\nExpected: Not 00000000-0000-0000-0000-000000000000\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync
<failure exception-type="Xunit.Sdk.EqualException">
    <message><![CDATA[Assert.Equal() Failure\nExpected: ed27419e-317a-43a7-be88-6b793b146141\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync
<failure exception-type="Xunit.Sdk.EqualException">
    <message><![CDATA[Assert.Equal() Failure\nExpected: 33f1669b-7f05-46a8-bf4c-f321de6083f6\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>

cc @steveisok

Author: MaximLipnin
Assignees: -
Labels:

area-System.Diagnostics.Tracing, os-android, os-ios
Milestone: -

@ghost
Copy link

ghost commented Jul 21, 2021

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details
  • BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity
<failure exception-type="Xunit.Sdk.NotEqualException">
    <message><![CDATA[Assert.NotEqual() Failure\nExpected: Not 00000000-0000-0000-0000-000000000000\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.StartStopCreatesActivity()
    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync
<failure exception-type="Xunit.Sdk.NotEqualException">
    <message><![CDATA[Assert.NotEqual() Failure\nExpected: Not 00000000-0000-0000-0000-000000000000\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.ActivityFlowsAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync
<failure exception-type="Xunit.Sdk.EqualException">
    <message><![CDATA[Assert.Equal() Failure\nExpected: ed27419e-317a-43a7-be88-6b793b146141\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdBeforeEventFlowsAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>
  • BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync
<failure exception-type="Xunit.Sdk.EqualException">
    <message><![CDATA[Assert.Equal() Failure\nExpected: 33f1669b-7f05-46a8-bf4c-f321de6083f6\nActual:   00000000-0000-0000-0000-000000000000]]></message>
    <stack-trace><![CDATA[   at BasicEventSourceTests.ActivityTracking.SetCurrentActivityIdAfterEventDoesNotFlowAsync()
    --- End of stack trace from previous location ---]]>
    </stack-trace>
</failure>

cc @steveisok

Author: MaximLipnin
Assignees: -
Labels:

area-Infrastructure-mono, area-System.Diagnostics.Tracing, os-android, os-ios
Milestone: -

@steveisok steveisok added this to the 7.0.0 milestone Jul 21, 2021
steveisok pushed a commit that referenced this issue Jul 22, 2021
@MaximLipnin
[iOS/tvOS/MacCatalyst] Disable some of the library tests due to failu…
f5ed68b 
…res (#56074)

It's to clean up the respective CI staging lanes.

The related issues:

[iOS/tvOS/MacCatalyst] Test failures in System.Diagnostics.Tracing.Tests #56073

[libraries][iOSSimulator] ImageTests.FromFile_NullFileName_ThrowsArgumentNullException fails  #56048

JitInfoIsPopulated failed with after is not greater than before #55712

[MacCatalyst] Test failures in System.Tests.OperatingSystemTests #56084

[MacCatalyst] App crash in System.Text.Json.SourceGeneration.Tests #56085
@mdh1418 mdh1418 mentioned this issue Jul 20, 2022
Merged
@steveisok
Copy link
Member

These are now enabled. Closing.

@mdh1418 mdh1418 mentioned this issue Aug 9, 2022
Closed
@mdh1418
Copy link
Member

mdh1418 commented Aug 9, 2022

These are still failing on tvOS

@mdh1418 mdh1418 reopened this Aug 9, 2022
@mdh1418 mdh1418 changed the title [iOS/tvOS/MacCatalyst] Test failures in System.Diagnostics.Tracing.Tests [tvOS] Test failures in System.Diagnostics.Tracing.Tests Aug 9, 2022
@mdh1418 mdh1418 modified the milestones: 7.0.0, 8.0.0 Aug 9, 2022
ViktorHofer pushed a commit to dotnet/winforms that referenced this issue Dec 5, 2022
@MaximLipnin
[iOS/tvOS/MacCatalyst] Disable some of the library tests due to failu…
796925b 
…res (dotnet/runtime#56074)

It's to clean up the respective CI staging lanes.

The related issues:

[iOS/tvOS/MacCatalyst] Test failures in System.Diagnostics.Tracing.Tests dotnet/runtime#56073

[libraries][iOSSimulator] ImageTests.FromFile_NullFileName_ThrowsArgumentNullException fails  dotnet/runtime#56048

JitInfoIsPopulated failed with after is not greater than before dotnet/runtime#55712

[MacCatalyst] Test failures in System.Tests.OperatingSystemTests dotnet/runtime#56084

[MacCatalyst] App crash in System.Text.Json.SourceGeneration.Tests dotnet/runtime#56085

Commit migrated from dotnet/runtime@f5ed68b
@marek-safar marek-safar modified the milestones: 8.0.0, Future Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mdh1418 mdh1418

Labels
area-System.Diagnostics.Tracing os-android os-ios Apple iOS
Projects
None yet
Milestone
Future
Development

No branches or pull requests
5 participants
@marek-safar @steveisok @MaximLipnin @lateralusX @mdh1418