Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jit/performance/codequality/benchmarksgame/k-nucleotide/k-nucleotide-9/k-nucleotide-9.sh #67675

Closed
runfoapp bot opened this issue Apr 6, 2022 · 9 comments
Assignees
Labels
area-Codegen-JIT-mono disabled-test The test is disabled in source code against the issue
Milestone

Comments

@runfoapp
Copy link

runfoapp bot commented Apr 6, 2022

Runfo Tracking Issue: jit/performance/codequality/benchmarksgame/k-nucleotide/k-nucleotide-9/k-nucleotide-9.sh

Build Definition Kind Run Name

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
0 0 0
@dotnet-issue-labeler dotnet-issue-labeler bot added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI untriaged New issue has not been triaged by the area owner labels Apr 6, 2022
@ghost
Copy link

ghost commented Apr 6, 2022

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

Runfo Creating Tracking Issue (data being generated)

Author: runfoapp[bot]
Assignees: -
Labels:

area-CodeGen-coreclr, untriaged

Milestone: -

@AndyAyersMS AndyAyersMS added area-Codegen-meta-mono and removed area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labels Apr 7, 2022
@AndyAyersMS
Copy link
Member

Updated area path.

@ViktorHofer ViktorHofer added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Apr 14, 2022
@agocke
Copy link
Member

agocke commented May 2, 2022

@SamMonoRT This looks to still be failing, can you assign it for investigation?

@SamMonoRT
Copy link
Member

Assigning to @naricc --- this test seems to be disabled on Android, iOS, WASM(https://github.com/dotnet/runtime/blob/main/src/tests/issues.targets), so not certain if this works in other configs. Could be a case of disabling the tests to get a Green CI for now, but we need to understand why it started failing.

@agocke - I verified my email, but don't seem to get access to the runfo tracking issue to see when the hits started. Is there a way to query for this test history, as to when it started failing, and is it failing deterministically on only certain lanes, possibly identify the first PR which hit the issue ?

@SamMonoRT
Copy link
Member

Failing test has been added to issues.target file to be excluded while we investigate. Removing blocking ci label and adding disabled-test instead.

@SamMonoRT SamMonoRT added this to the 7.0.0 milestone May 6, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label May 6, 2022
@SamMonoRT SamMonoRT added disabled-test The test is disabled in source code against the issue and removed blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' labels May 6, 2022
@jakobbotsch
Copy link
Member

This failed again in https://dev.azure.com/dnceng/public/_build/results?buildId=1763118&view=results.
It looks like it should also be disabled under the "llvmfullaot" variant.

@SamMonoRT
Copy link
Member

SamMonoRT commented May 11, 2022

cc @naricc - seems like an issues.target grouping issue to me. Shouldn't all mono runtime tests overrule the sub categorization?

@naricc naricc modified the milestones: 7.0.0, 8.0.0 Aug 1, 2022
@SamMonoRT
Copy link
Member

SamMonoRT commented May 17, 2023

Don't see new recent failures, but we still need to understand why this fails for mono lanes. @jandupej to take a look whats needed to re-enable the test in CI pipelines

@SamMonoRT SamMonoRT assigned jandupej and unassigned naricc May 17, 2023
@jandupej
Copy link
Member

jandupej commented Jun 6, 2023

Checked the test locally repeatedly and in CI (including extra-platforms). No failures were encountered. Reenabled test in #87058. Closing.

@jandupej jandupej closed this as completed Jun 6, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Codegen-JIT-mono disabled-test The test is disabled in source code against the issue
Projects
None yet
Development

No branches or pull requests

7 participants