Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable k-nucleotide-9 in llvmfullaot #69173

Merged

Conversation

jakobbotsch
Copy link
Member

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented May 11, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

#67675 (comment)

cc @SamMonoRT @naricc

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-Infrastructure-mono

Milestone: -

@jakobbotsch
Copy link
Member Author

This conflicted with #69009 that also disabled this test in llvmfullaot, but it looks like the test path from that PR has an extra space, so changed this PR to fix that problem.

@jakobbotsch
Copy link
Member Author

@ManickaP Is it correct that the disabling of this test is pointing to #52977 instead of #67675?

@ManickaP
Copy link
Member

ManickaP commented May 11, 2022

I was disabling it because it was failing due to System.Net.Quic being excluded from MonoAOT. But feel free to change the linked issue.
Edit: When I disabled the tests, I just disabled all failing in my pipeline run. I wasn't pedantic in checking each of the for the exact root cause though.

@jakobbotsch jakobbotsch merged commit 9656b47 into dotnet:main May 12, 2022
@jakobbotsch jakobbotsch deleted the disable-k-nucleotide-9-llvmfullaot branch May 12, 2022 08:50
@ghost ghost locked as resolved and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants