Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MONO][TEST] Disabled k-nucleotide test on mono #68910

Merged
merged 1 commit into from
May 6, 2022

Conversation

naricc
Copy link
Contributor

@naricc naricc commented May 5, 2022

I am disabling this test for now while I investigate this issue: #67675

@naricc naricc requested a review from SamMonoRT May 5, 2022 15:22
@ghost ghost assigned naricc May 5, 2022
@ghost
Copy link

ghost commented May 5, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

I am disabling this test for now while I investigate this issue: #67675

Author: naricc
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@naricc naricc requested a review from fanyang-mono May 5, 2022 15:22
Copy link
Member

@fanyang-mono fanyang-mono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add disabled-test label to the issue #67675 upon merging this PR.

@@ -2755,6 +2755,9 @@
<ExcludeList Include = "$(XunitTestBinBase)/tracing/eventactivityidcontrol/eventactivityidcontrol/**">
<Issue>needs triage</Issue>
</ExcludeList>
<ExcludeList Include = "$(XunitTestBinBase)/JIT/Performance/CodeQuality/BenchmarksGame/k-nucleotide/k-nucleotide-9/**">
<Issue>https://github.com/dotnet/runtime/issues/67675</Issue>
</ExcludeList>
</ItemGroup>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this test exclusion from platform specific blocks in this file as part of this change or will you do that once we understand the actual issue ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it there, because I am not sure if there are separate issues blocking it on those platforms or what.

@SamMonoRT
Copy link
Member

Failures are unrelated.

@SamMonoRT SamMonoRT merged commit e386044 into dotnet:main May 6, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants