Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse/remove projects under src/installer/tests/Assets/TestProjects #77807

Closed
Tracked by #77800 ...
elinor-fung opened this issue Nov 2, 2022 · 5 comments
Closed
Tracked by #77800 ...
Labels
area-Host test-enhancement Improvements of test source code
Milestone

Comments

@elinor-fung
Copy link
Member

elinor-fung commented Nov 2, 2022

Many projects in src/installer/tests/Assets/TestProjects only have minor differences - multiple projects can become one with different behaviour based on command line arguments to reduce the cost of restoring/building the test assets (and including them in a helix payload when we get to that point)

Likely candidates: PortableApp*, RuntimeProperties, AppWith*, LightupApp

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 2, 2022
@elinor-fung elinor-fung added test-enhancement Improvements of test source code area-Host and removed untriaged New issue has not been triaged by the area owner labels Nov 2, 2022
@elinor-fung elinor-fung added this to the 8.0.0 milestone Nov 2, 2022
@ghost
Copy link

ghost commented Nov 2, 2022

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: elinor-fung
Assignees: -
Labels:

test-enhancement, area-Host

Milestone: -

@elinor-fung elinor-fung mentioned this issue Nov 2, 2022
10 tasks
@am11
Copy link
Member

am11 commented Nov 3, 2022

@elinor-fung, are these operations relevant to host testing:

// A small operation involving NewtonSoft.Json to ensure the assembly is loaded properly
var t = typeof(Newtonsoft.Json.JsonReader);
If it is not possible that the assembly loading functionality could regress without breaking other (non-host) tests in the runtime repo (e.g. test_dependencies uses live host for libraries tests), we can clean up Newtonsoft dependency from TestProjects assets as well.

@elinor-fung
Copy link
Member Author

For most cases, I think they are not relevant. I think they were mostly there to test basic dependency resolution, but also muddied with relying on the SDK/build. Aside from what you mentioned about coverage via the live host being used in libraries tests now, since those TestProjects assets were added @vitek-karas has done a lot of work to create more targeted component tests for that area.

There are a couple tests that intentionally do things to target moving around / configuring dependencies that use it, but I think they could/should be changed to do things differently.

@elinor-fung
Copy link
Member Author

The tests been moved away from these projects to use pre-built test assets now. And it has gone from 40+ projects copied/built during test run to 18 pre-built test assets.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host test-enhancement Improvements of test source code
Projects
Archived in project
Development

No branches or pull requests

2 participants