-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse/remove projects under src/installer/tests/Assets/TestProjects #77807
Comments
I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue Detailsnull
|
@elinor-fung, are these operations relevant to host testing:
|
For most cases, I think they are not relevant. I think they were mostly there to test basic dependency resolution, but also muddied with relying on the SDK/build. Aside from what you mentioned about coverage via the live host being used in libraries tests now, since those TestProjects assets were added @vitek-karas has done a lot of work to create more targeted component tests for that area. There are a couple tests that intentionally do things to target moving around / configuring dependencies that use it, but I think they could/should be changed to do things differently. |
The tests been moved away from these projects to use pre-built test assets now. And it has gone from 40+ projects copied/built during test run to 18 pre-built test assets. |
Many projects in src/installer/tests/Assets/TestProjects only have minor differences - multiple projects can become one with different behaviour based on command line arguments to reduce the cost of restoring/building the test assets (and including them in a helix payload when we get to that point)
Likely candidates: PortableApp*, RuntimeProperties, AppWith*, LightupApp
The text was updated successfully, but these errors were encountered: