Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use HostApiInvokerApp for BundleProbe test (remove BundleProbeTester app) #91636

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Use HostApiInvokerApp for BundleProbe test (remove BundleProbeTester app) #91636

merged 2 commits into from
Sep 6, 2023

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Sep 5, 2023 •
edited
Loading

  • Use HostApiInvokerApp / host runtime contract instead of a separate app for testing the bundle probe
  • Make test app take arguments of what to probe and output result (that test case validates) instead of having the logic itself
  • Remove BundleProbeTester app

Contributes to #77807

@elinor-fung elinor-fung added test-enhancement Improvements of test source code area-Host labels Sep 5, 2023
@ghost ghost assigned elinor-fung Sep 5, 2023
@ghost
Copy link

ghost commented Sep 5, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use HostApiInvokerApp / host runtime contract instead of a separate app for testing the bundle probe
  • Make test app take arguments of what to probe and output result (that test case validates) instead of having the logic itself
  • Remove BundleProbeTester app
Author: elinor-fung
Assignees: -
Labels:

test-enhancement, area-Host
Milestone: -

@elinor-fung elinor-fung merged commit 76d17b2 into dotnet:main Sep 6, 2023
@elinor-fung elinor-fung deleted the removeBundleProbeTester branch September 6, 2023 19:15
@ghost ghost locked as resolved and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vitek-karas vitek-karas vitek-karas approved these changes

Assignees

@elinor-fung elinor-fung

Labels
area-Host test-enhancement Improvements of test source code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elinor-fung @vitek-karas