Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of Newtonsoft.Json from host test assets #84745

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

elinor-fung
Copy link
Member

We've moved all the host tests that were using Newtonsoft.Json for dependency testing to do things differently. So we can now get rid of the dependency from the test assets - thanks to @am11 for calling it out in #77807 (comment)

@elinor-fung elinor-fung added test-enhancement Improvements of test source code area-Host labels Apr 13, 2023
@elinor-fung elinor-fung requested a review from vitek-karas April 13, 2023 00:41
@ghost ghost assigned elinor-fung Apr 13, 2023
@ghost
Copy link

ghost commented Apr 13, 2023

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

We've moved all the host tests that were using Newtonsoft.Json for dependency testing to do things differently. So we can now get rid of the dependency from the test assets - thanks to @am11 for calling it out in #77807 (comment)

Author: elinor-fung
Assignees: -
Labels:

test-enhancement, area-Host

Milestone: -

@elinor-fung elinor-fung merged commit d271427 into dotnet:main Apr 13, 2023
@elinor-fung elinor-fung deleted the hostTests-noNewtonsoft branch April 13, 2023 18:58
@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-Host test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants