Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] dotnet-runtime-perf pipeline completely broken #77883

Closed
radical opened this issue Nov 4, 2022 · 4 comments
Closed

[wasm] dotnet-runtime-perf pipeline completely broken #77883

radical opened this issue Nov 4, 2022 · 4 comments
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Milestone
8.0.0

Comments

@radical
Copy link
Member

radical commented Nov 4, 2022 •
edited by build-analysis bot
Loading

The wasm perf runs are broken after #77852 . I haven't investigated why that would be breaking the runs, but all of the wasm ones broke. I don't know if some of the non-wasm ones are breaking too.

  1. previous passing pipeline run which is building exactly the previous commit
  2. and the failing run

The wasm runs are failing with:

[2022/11/03 22:06:50][INFO] $ dotnet exec MicroBenchmarks.dll --anyCategories Libraries Runtime "" --category-exclusion-filter NoInterpreter NoWASM NoMono --wasmEngine /home/helixbot/.jsvu/v8 --cli /home/helixbot/work/B85009EF/p/dotnet/dotnet --wasmDataDir /home/helixbot/work/B85009EF/p/wasm-data --logBuildOutput --generateBinLog "" --partition-count 30 --partition-index 10 --artifacts /home/helixbot/work/B85009EF/w/9F070920/e/artifacts/BenchmarkDotNet.Artifacts --packages /home/helixbot/work/B85009EF/w/9F070920/e/performance/artifacts/packages --runtimes wasmnet70 --buildTimeout 1200
[2022/11/03 22:06:50][INFO] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
[2022/11/03 22:06:50][INFO] 
[2022/11/03 22:06:50][INFO] File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
[2022/11/03 22:06:50][INFO] $ popd
[2022/11/03 22:06:50][ERROR] Process exited with status -6
[2022/11/03 22:06:50][INFO] Run failure registered
Traceback (most recent call last):
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/benchmarks_ci.py", line 326, in <module>
    __main(sys.argv[1:])
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/benchmarks_ci.py", line 295, in __main
    args
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/micro_benchmarks.py", line 357, in run
    status = dotnet.exec(asm_path, success_exit_codes, verbose, *run_args)
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/dotnet.py", line 54, in exec
    return RunCommand(cmdline, success_exit_codes, verbose=verbose).run(working_dir)
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/performance/common.py", line 251, in run
    returncode, quoted_cmdline)
subprocess.CalledProcessError: Command '$ dotnet exec MicroBenchmarks.dll --anyCategories Libraries Runtime "" --category-exclusion-filter NoInterpreter NoWASM NoMono --wasmEngine /home/helixbot/.jsvu/v8 --cli /home/helixbot/work/B85009EF/p/dotnet/dotnet --wasmDataDir /home/helixbot/work/B85009EF/p/wasm-data --logBuildOutput --generateBinLog "" --partition-count 30 --partition-index 10 --artifacts /home/helixbot/work/B85009EF/w/9F070920/e/artifacts/BenchmarkDotNet.Artifacts --packages /home/helixbot/work/B85009EF/w/9F070920/e/performance/artifacts/packages --runtimes wasmnet70 --buildTimeout 1200' died with <Signals.SIGABRT: 6>.

cc @lewing @AaronRobinsonMSFT

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@radical radical added arch-wasm WebAssembly architecture perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Nov 4, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Nov 4, 2022
@ghost
Copy link

ghost commented Nov 4, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

The wasm perf runs are broken after #77852 . I haven't investigated why that would be breaking the runs, but all of the wasm ones broke. I don't know if some of the non-wasm ones are breaking too.

  1. previous passing pipeline run which is building exactly the previous commit
  2. and the failing run

The wasm runs are failing with:

[2022/11/03 22:06:50][INFO] $ dotnet exec MicroBenchmarks.dll --anyCategories Libraries Runtime "" --category-exclusion-filter NoInterpreter NoWASM NoMono --wasmEngine /home/helixbot/.jsvu/v8 --cli /home/helixbot/work/B85009EF/p/dotnet/dotnet --wasmDataDir /home/helixbot/work/B85009EF/p/wasm-data --logBuildOutput --generateBinLog "" --partition-count 30 --partition-index 10 --artifacts /home/helixbot/work/B85009EF/w/9F070920/e/artifacts/BenchmarkDotNet.Artifacts --packages /home/helixbot/work/B85009EF/w/9F070920/e/performance/artifacts/packages --runtimes wasmnet70 --buildTimeout 1200
[2022/11/03 22:06:50][INFO] Unhandled exception. System.IO.FileNotFoundException: Could not load file or assembly 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.
[2022/11/03 22:06:50][INFO] 
[2022/11/03 22:06:50][INFO] File name: 'System.Runtime, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
[2022/11/03 22:06:50][INFO] $ popd
[2022/11/03 22:06:50][ERROR] Process exited with status -6
[2022/11/03 22:06:50][INFO] Run failure registered
Traceback (most recent call last):
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/benchmarks_ci.py", line 326, in <module>
    __main(sys.argv[1:])
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/benchmarks_ci.py", line 295, in __main
    args
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/micro_benchmarks.py", line 357, in run
    status = dotnet.exec(asm_path, success_exit_codes, verbose, *run_args)
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/dotnet.py", line 54, in exec
    return RunCommand(cmdline, success_exit_codes, verbose=verbose).run(working_dir)
  File "/home/helixbot/work/B85009EF/w/9F070920/e/performance/scripts/performance/common.py", line 251, in run
    returncode, quoted_cmdline)
subprocess.CalledProcessError: Command '$ dotnet exec MicroBenchmarks.dll --anyCategories Libraries Runtime "" --category-exclusion-filter NoInterpreter NoWASM NoMono --wasmEngine /home/helixbot/.jsvu/v8 --cli /home/helixbot/work/B85009EF/p/dotnet/dotnet --wasmDataDir /home/helixbot/work/B85009EF/p/wasm-data --logBuildOutput --generateBinLog "" --partition-count 30 --partition-index 10 --artifacts /home/helixbot/work/B85009EF/w/9F070920/e/artifacts/BenchmarkDotNet.Artifacts --packages /home/helixbot/work/B85009EF/w/9F070920/e/performance/artifacts/packages --runtimes wasmnet70 --buildTimeout 1200' died with <Signals.SIGABRT: 6>.

cc @lewing @AaronRobinsonMSFT

Author: radical
Assignees: -
Labels:

arch-wasm, perf-pipeline
Milestone: -

@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Nov 4, 2022
@marek-safar marek-safar added this to the 8.0.0 milestone Nov 4, 2022
radical added a commit to radical/runtime that referenced this issue Nov 4, 2022
@radical
Revert "Remove "wprintf" from PAL (dotnet#77852)"
1a19c6b 
This completely broke `dotnet-runtime-perf` pipeline for wasm runs.

This reverts commit 8036885.

Issue: dotnet#77883
@radical radical mentioned this issue Nov 4, 2022
Closed
@radical
Copy link
Member Author

radical commented Nov 4, 2022

  • I tested with Aaron's commit (8036885) intact
  • Between the two CI runs:

cc @LoopedBard3 @ericstj

@AaronRobinsonMSFT this looks completely unrelated to your PR 👍

@radical radical mentioned this issue Nov 4, 2022
Merged
@radical radical added the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Nov 4, 2022
@runfoapp runfoapp bot mentioned this issue Nov 4, 2022
Closed
@AaronRobinsonMSFT
Copy link
Member

@AaronRobinsonMSFT this looks completely unrelated to your PR 👍

❤️ Thanks @radical. Your diligence here is most appreciated.

@radical
Copy link
Member Author

radical commented Nov 14, 2022

Closing this as the pipeline has been green after the reverts, and changes.

@radical radical closed this as completed Nov 14, 2022
@radical radical removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label Nov 14, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Infrastructure-mono perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@radical @marek-safar @AaronRobinsonMSFT