Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove "wprintf" from PAL (#77852)" #77913

Closed
wants to merge 1 commit into from

Conversation

radical
Copy link
Member

@radical radical commented Nov 4, 2022

This completely broke dotnet-runtime-perf pipeline for wasm runs.

This reverts commit 8036885.

Issue: #77883

This completely broke `dotnet-runtime-perf` pipeline for wasm runs.

This reverts commit 8036885.

Issue: dotnet#77883
@radical radical added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Regression perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines labels Nov 4, 2022
@ghost ghost assigned radical Nov 4, 2022
@radical
Copy link
Member Author

radical commented Nov 4, 2022

/azp run runtime-wasm-perf

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@AaronRobinsonMSFT
Copy link
Member

@radical It would be most helpful if you could root out what part of WASM is failing and potential reproduction steps here.

@radical
Copy link
Member Author

radical commented Nov 4, 2022

@radical It would be most helpful if you could root out what part of WASM is failing and potential reproduction steps here.

I was was able to confirm that this is only happening for wasm. So, I'm trying to check if anything else could be responsible here.

@radical
Copy link
Member Author

radical commented Nov 4, 2022

  • I tested with your commit intact
  • Between the two CI runs:

cc @LoopedBard3 @ericstj

@AaronRobinsonMSFT this looks completely unrelated to your PR 👍

@radical radical removed the request for review from AaronRobinsonMSFT November 4, 2022 20:44
@radical radical closed this Nov 4, 2022
@radical radical deleted the revert-wprintf branch November 4, 2022 20:46
LoopedBard3 added a commit to LoopedBard3/performance that referenced this pull request Nov 4, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-PAL-coreclr blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' perf-pipeline Issues with dotnet-runtime-perf, or runtime-wasm-perf pipelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants