-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Blazor/AOT tests failing because Microsoft.JSInterop.WebAssembly
is not getting skipped for AOT
#85010
Comments
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsWBT tests
This is with sdk
|
- For blazor AOT, the blazor targets explicitly skip `Microsoft.JSInterop.WebAssembly.dll` in `_GatherBlazorFilesToPublish` target. - it is done by marking the assembly item in `@(WasmAssembliesToBundle)` with `%(AOT_InternalForceToInterpret)="true"`. - this target needs to run after `_GatherWasmFilesToPublish` which builds the list of assemblies to AOT in `@(WasmAssembliesToBundle)` - the order of these two targets was corrected in #31640 - but the changes in #31559 added the target twice, resulting in the order: `_GatherBlazorFilesToPublish;_GatherWasmFilesToPublish;_GatherBlazorFilesToPublish` 1. in which the first `_GatherBlazorFilesToPublish` tries to remove the assembly from an empty list 2. then `_GatherWasmFilesToPublish` populates the list 3. and the last instance of `_GatherBlazorFilesToPublish` target doesn't run because it has already run before in (2). - thus the assembly never gets removed from the list. Fixes: dotnet/runtime#85010
- For blazor AOT, the blazor targets explicitly skip `Microsoft.JSInterop.WebAssembly.dll` in `_GatherBlazorFilesToPublish` target. - it is done by marking the assembly item in `@(WasmAssembliesToBundle)` with `%(AOT_InternalForceToInterpret)="true"`. - this target needs to run after `_GatherWasmFilesToPublish` which builds the list of assemblies to AOT in `@(WasmAssembliesToBundle)` - the order of these two targets was corrected in #31640 - but the changes in #31559 added the target twice, resulting in the order: `_GatherBlazorFilesToPublish;_GatherWasmFilesToPublish;_GatherBlazorFilesToPublish` 1. in which the first `_GatherBlazorFilesToPublish` tries to remove the assembly from an empty list 2. then `_GatherWasmFilesToPublish` populates the list 3. and the last instance of `_GatherBlazorFilesToPublish` target doesn't run because it has already run before in (2). - thus the assembly never gets removed from the list. Fixes: dotnet/runtime#85010
WBT tests
Workloads-Wasm.Build.Tests.Blazor.MiscTests
breaking on rolling build. Log:This is with sdk
8.0.100-preview.4.23218.17
, and fails because ofhttps://github.com/dotnet/sdk/blob/4ea3e8304c21022bbea72a29154b7602af4f9239/src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets#L22
and https://github.com/dotnet/sdk/blob/4ea3e8304c21022bbea72a29154b7602af4f9239/src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets#L60 . Removing the duplicate at line 60 fixes the issue.
Known Issue Error Message
Fill the error message using known issues guidance.
Report
Summary
The text was updated successfully, but these errors were encountered: