Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] WBT: Re-enable previously disabled test #85009

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

radical
Copy link
Member

@radical radical commented Apr 18, 2023

NativeBuild_WithDeployOnBuild_UsedByVS

The filed issue possibly incorrectly identified the issue.

      []   Restored C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj (in 3.34 sec).
      [] C:\helix\work\workitem\e\dotnet-latest\sdk\8.0.100-preview.4.23212.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(287,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []
      [] Build FAILED.
      []
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []     0 Warning(s)
      []     3 Error(s)

This error has been seen intermittently seen before, and is likely caused by Program.cs having some error messages instead of the code.

Fixes #84722

`NativeBuild_WithDeployOnBuild_UsedByVS`

The filed issue possibly incorrectly identified the issue.
```
      []   Restored C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj (in 3.34 sec).
      [] C:\helix\work\workitem\e\dotnet-latest\sdk\8.0.100-preview.4.23212.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(287,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []
      [] Build FAILED.
      []
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []     0 Warning(s)
      []     3 Error(s)
```

This error has been seen intermittently seen before, and is likely
caused by `Program.cs` having some error messages instead of the code.

Fixes dotnet#84722
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Apr 18, 2023
@ghost ghost assigned radical Apr 18, 2023
@ghost
Copy link

ghost commented Apr 18, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

NativeBuild_WithDeployOnBuild_UsedByVS

The filed issue possibly incorrectly identified the issue.

      []   Restored C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj (in 3.34 sec).
      [] C:\helix\work\workitem\e\dotnet-latest\sdk\8.0.100-preview.4.23212.2\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(287,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []
      [] Build FAILED.
      []
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1001: Identifier expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,49): error CS1002: ; expected [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      [] C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\Program.cs(3,52): error CS1526: A new expression requires an argument list or (), [], or {} after type [C:\helix\work\workitem\e\wbt\blz_deploy_on_build_Release_True_5i4l1wn0.new\blz_deploy_on_build_Release_True_5i4l1wn0.new.csproj]
      []     0 Warning(s)
      []     3 Error(s)

This error has been seen intermittently seen before, and is likely caused by Program.cs having some error messages instead of the code.

Fixes #84722

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical
Copy link
Member Author

radical commented Apr 18, 2023

This instead fails with:

      Wasm.Build.Tests.Blazor.MiscTests.NativeBuild_WithDeployOnBuild_UsedByVS(config: "Debug", nativeRelink: False) [FAIL]
        Assert.DoesNotContain() Failure
        Found:    Microsoft.JSInterop.WebAssembly.dll -> Microsoft.JSInterop.WebAssembly.dll.bc

.. which is because
https://github.com/dotnet/sdk/blob/4ea3e8304c21022bbea72a29154b7602af4f9239/src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets#L22
and https://github.com/dotnet/sdk/blob/4ea3e8304c21022bbea72a29154b7602af4f9239/src/BlazorWasmSdk/Targets/Microsoft.NET.Sdk.BlazorWebAssembly.6_0.targets#L60 . Removing the duplicate at line 60 fixes the issue.

@radical
Copy link
Member Author

radical commented Apr 18, 2023

Issue: #85010

@lewing lewing closed this Apr 20, 2023
@lewing lewing reopened this Apr 20, 2023
@radical radical merged commit 2087ceb into dotnet:main Apr 21, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] WasmBuildTests NativeBuild_WithDeployOnBuild_UsedByVS is failing and will be disabled
3 participants