Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply params ReadOnlySpan overloads without params keyword #101308

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Reapply params ReadOnlySpan overloads without params keyword #101308

merged 3 commits into from
Apr 23, 2024

Conversation

jozkee
Copy link
Member

@jozkee jozkee commented Apr 19, 2024

@jozkee jozkee added this to the 9.0.0 milestone Apr 19, 2024
@jozkee jozkee requested a review from stephentoub April 19, 2024 19:37
@jozkee jozkee self-assigned this Apr 19, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@jozkee jozkee mentioned this pull request Apr 19, 2024
Merged
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

This was referenced Apr 20, 2024
Closed
Closed
Closed
@build-analysis build-analysis bot mentioned this pull request Apr 22, 2024
Closed
@jozkee jozkee mentioned this pull request Apr 23, 2024
Closed
@jozkee jozkee merged commit 1c824d9 into dotnet:main Apr 23, 2024
145 of 150 checks passed
@jozkee jozkee deleted the paramsspan2 branch April 23, 2024 02:58
@jozkee jozkee mentioned this pull request Apr 24, 2024
Merged
This was referenced Apr 26, 2024
Closed
Closed
matouskozak pushed a commit to matouskozak/runtime that referenced this pull request Apr 30, 2024
@jozkee @matouskozak
Reapply params ReadOnlySpan overloads without params keyword (dotnet#…
c18497a 
…101308)

* Reapply "Add params ReadOnlySpan<T> overloads (dotnet#100898)" (dotnet#101123)

This reverts commit 3e569f5.

* Comment-out params keyword

* Remove /*params*/ from ref
michaelgsharp pushed a commit to michaelgsharp/runtime that referenced this pull request May 9, 2024
@jozkee @michaelgsharp
Reapply params ReadOnlySpan overloads without params keyword (dotnet#…
5679023 
…101308)

* Reapply "Add params ReadOnlySpan<T> overloads (dotnet#100898)" (dotnet#101123)

This reverts commit 3e569f5.

* Comment-out params keyword

* Remove /*params*/ from ref
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees

@jozkee jozkee

Labels
area-System.Memory
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jozkee @stephentoub