-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reapply keyword params
#101499
Reapply keyword params
#101499
Conversation
Note regarding the
|
We won't be able to merge this until the C# compiler is updated to guard overload resolution with params span on LangVersion. |
/azp run |
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Added When you commit this breaking change:
Tagging @dotnet/compat for awareness of the breaking change. |
@jozkee, why did you mark this as breaking? What is breaking about it? |
source breaking? |
Can you elaborate? |
There's a case where a collection expression can't resolve between Additionally, do we not want to document cases of types with conditions similar to StringValues? |
Currently, the better conversion rules for collection expressions treat this case as ambiguous. Perhaps there should be an additional rule to prefer |
I thought that was part of the first-class span support. Is it not, @333fred? |
Unfortunately, implicit conversions from first-class span support may not be sufficient for a collection expression argument since implicit conversions are only considered in better conversion when the types are not span types.
|
Co-authored-by: Stephen Toub <stoub@microsoft.com>
This is tracked by dotnet/roslyn#73857. |
Note for breaking change doc: If this ship as is, it should be pointed out that See #102822 (comment). |
Closes #101261.
Closes #77873.
Continuation of #101308.