Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JsonMarshal.GetRawUtf8Value #104595

Merged
merged 5 commits into from
Jul 10, 2024
Merged

Add JsonMarshal.GetRawUtf8Value #104595

merged 5 commits into from
Jul 10, 2024

Conversation

eiriktsarpalis
Copy link
Member

@eiriktsarpalis eiriktsarpalis commented Jul 9, 2024 •
edited
Loading

Fix #77666. Pending API approval.

cc @annelo-msft @KrzysztofCwalina

@eiriktsarpalis eiriktsarpalis self-assigned this Jul 9, 2024
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@eiriktsarpalis eiriktsarpalis added this to the 9.0.0 milestone Jul 9, 2024
@dotnet dotnet deleted a comment from dotnet-issue-labeler bot Jul 9, 2024
This was referenced Jul 9, 2024
Open
Closed
@eiriktsarpalis eiriktsarpalis changed the title Add JsonMarshal.TryGetRawValue Add JsonMarshal.GetRawUtf8Value Jul 9, 2024
@eiriktsarpalis
Copy link
Member Author

Updated to the approved API shape.

This was referenced Jul 9, 2024
Open
Open
Open
Closed
stephentoub
stephentoub approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the test naming comment, LGTM

This was referenced Jul 10, 2024
Open
Closed
@eiriktsarpalis eiriktsarpalis merged commit 635f9af into dotnet:main Jul 10, 2024
74 of 83 checks passed
@eiriktsarpalis eiriktsarpalis deleted the jsonmarshal-jsonelement branch July 10, 2024 22:56
matouskozak added a commit to matouskozak/runtime that referenced this pull request Jul 11, 2024
@matouskozak
Revert "Add JsonMarshal.GetRawUtf8Value (dotnet#104595)"
dfd5dfb 
This reverts commit 635f9af.
@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@annelo-msft annelo-msft annelo-msft left review comments

@justindbaur justindbaur justindbaur left review comments

@stephentoub stephentoub stephentoub approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json new-api-needs-documentation
Projects
None yet
Milestone
9.0.0
Development

Successfully merging this pull request may close these issues.

Add JsonElement.ValueSpan
4 participants
@eiriktsarpalis @stephentoub @justindbaur @annelo-msft