Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Type System Equivalence Checks #106498

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

ivdiazsa
Copy link
Member

Fixes issue #96242.

This is the initial draft of the solution to address the aforementioned issue. Debugging through Crossgen2 and the compiler for ReadyToRun, we found that on Windows, we were computing and using type identifiers from Guid's, whether there is interop or not. As far as we're concerned, outside of those scenarios we shouldn't need to be doing those checks.

So, initially I want to ask for your guidance more than direct review feedback. Are we approaching this the right way? Is this the right solution? Starting this as draft since this discussion is needed beforehand.

@davidwrighton @jkotas @MichalStrehovsky

@ivdiazsa ivdiazsa added this to the 9.0.0 milestone Aug 15, 2024
@ivdiazsa ivdiazsa linked an issue Aug 15, 2024 that may be closed by this pull request
@steveisok
Copy link
Member

@davidwrighton do you see any harm in backporting this change to net8?

@ivdiazsa
Copy link
Member Author

/azp run runtime-coreclr outerloop

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa
Copy link
Member Author

Failures are known and unrelated. Could we get a review now? @davidwrighton @MichalStrehovsky @lambdageek @kg @steveisok

@steveisok steveisok self-requested a review August 19, 2024 20:50
Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only outstanding question I have is if this is backport worthy?

@davidwrighton
Copy link
Member

I think this is eligible for backport. It looks reasonable to me.

@ivdiazsa
Copy link
Member Author

I think this is eligible for backport. It looks reasonable to me.

Perfect thanks! Will merge this and start working on the backport PR to .NET 8.

@ivdiazsa ivdiazsa merged commit b28d3f8 into dotnet:main Aug 19, 2024
137 of 140 checks passed
@steveisok
Copy link
Member

/backport to release/9.0-rc1

Copy link
Contributor

Started backporting to release/9.0-rc1: https://github.com/dotnet/runtime/actions/runs/10461925315

@steveisok
Copy link
Member

/backport to release/8.0-staging

Copy link
Contributor

Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/10461927413

@ivdiazsa
Copy link
Member Author

/backport to release/9.0

Copy link
Contributor

Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/10477927221

@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduced .NET8 R2R performance
5 participants