Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Type System Equivalence Checks #106498

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix Type System Equivalence Checks #106498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
494fe10
Initial fix for the type not being read bug.
ivdiazsa Aug 15, 2024
3dd0a78
Addressed initial feedback to fully fix the bug.
ivdiazsa Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/coreclr/tools/Common/TypeSystem/Ecma/EcmaType.TypeEquivalence.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ private TypeIdentifierData ComputeTypeIdentifierData()
if (this.HasCustomAttribute("System.Runtime.InteropServices", "ImportedFromTypeLibAttribute") || this.HasCustomAttribute("System.Runtime.InteropServices", "PrimaryInteropAssemblyAttribute"))
{
lambdageek marked this conversation as resolved.
Show resolved Hide resolved
// This type has a TypeIdentifier attribute if it has an appropriate shape to be considered type equivalent
}

if (!TypeHasCharacteristicsRequiredToBeTypeEquivalent)
return null;
if (!TypeHasCharacteristicsRequiredToBeTypeEquivalent)
return null;

_data = ComputeTypeIdentifierFromGuids();
_data = ComputeTypeIdentifierFromGuids();
return _data;
lambdageek marked this conversation as resolved.
Show resolved Hide resolved
}
}

return null;
Expand Down
Loading