Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0-rc1] Fix build break in CrossAOT_Mono crossaot builds #106589

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 18, 2024

Backport of #106578 to release/9.0-rc1

/cc @jkotas

Customer Impact

  • Customer reported
  • Found internally

Product does not build

Regression

  • Yes
  • No

Regression introduced by Visual Studio update on Windows build machines. #defines used by libz-ng started colliding with newly introduced symbols in Windows SDK.

Testing

Build passes

Risk

Low

Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@jkotas jkotas requested review from carlossanlop and lewing August 18, 2024 17:41
@lewing lewing added the Servicing-approved Approved for servicing release label Aug 18, 2024
@lewing
Copy link
Member

lewing commented Aug 18, 2024

this is tell mode due to the broken official build

@lewing
Copy link
Member

lewing commented Aug 18, 2024

/ba-g analysis is always red on failure in servicing, issues are all logged and unrelated

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants