Fix RidAssetResolution test to open shared framework file with read share access #107112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Aug 28, 2024
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
…access (dotnet#107112) The `RidAssetResolution` test was reading Microsoft.NETCoreApp.deps.json in a non-shareable way, which could result in other tests failing when trying to run an application (since that reads the .deps.json). This changes the test to open with `FileShare.Read` by going through `File.OpenRead`. The other two I just switched to `File.OpenRead` from `File.Open` with the equivalent arguments for consistency with the rest of HostModel and host tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RidAssetResolutiontest was reading Microsoft.NETCoreApp.deps.json in a non-shareable way, which could result in other tests failing when trying to run an application (since that reads the .deps.json). This changes the test to open withFileShare.Readby going throughFile.OpenRead.The other two I just switched to
File.OpenReadfromFile.Openwith the equivalent arguments for consistency with the rest of HostModel and host tests.Fixes #103743
cc @dotnet/appmodel @AaronRobinsonMSFT