[release/9.0] [mono] Fix swizzle_mask type #107602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
That was catched by llvm debug asserts, the mask should be vector of 16 int8
github-actions
bot
requested review from
fanyang-mono and
steveisok
as code owners
|
Tagging subscribers to this area: @lambdageek, @steveisok |
lewing
approved these changes
Sep 10, 2024
This was referenced Sep 11, 2024
|
@lewing can we get the template filled in? |
jeffschwMSFT
approved these changes
Sep 12, 2024
|
@lewing please take a look at the PR failures |
|
@lewing @radekdoulik today is the snap, please take a look at the PR failures |
|
/ba-g BA is red because this is a release branch, failures are known |
|
@jeffschwMSFT both this and the other look fine now |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #107460 to release/9.0
/cc @lambdageek @radekdoulik
Customer Impact
When working though llvm issues it was discovered that the wrong llvm type was used when constructing the Wasm SIMD intrinsic swizzle mask. The fixes a correctness issue that would otherwise appear when working with llvm
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
[How was the fix verified? How was the issue missed previously? What tests were added?]
Risk
Low