Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up code with NET8_0_OR_GREATER #109507

Merged
merged 6 commits into from
Nov 7, 2024

Revert changes in System.Collections due to reference from netstandar…

6549154
Select commit
Loading
Failed to load commit list.
Merged

Clean up code with NET8_0_OR_GREATER #109507

Revert changes in System.Collections due to reference from netstandar…
6549154
Select commit
Loading
Failed to load commit list.
Azure Pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests) failed Nov 6, 2024 in 23m 57s

Build osx-x64 Debug Mono_MiniJIT_LibrariesTests failed

Annotations

Check failure on line 12 in src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs#L12

src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs(12,35): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'ArgumentNullException' does not contain a definition for 'ThrowIfNull'

Check failure on line 23 in src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs#L23

src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs(23,41): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'ArgumentOutOfRangeException' does not contain a definition for 'ThrowIfNegative'

Check failure on line 24 in src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs#L24

src/libraries/System.Private.CoreLib/src/System/Collections/ObjectModel/CollectionHelpers.cs(24,41): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'ArgumentOutOfRangeException' does not contain a definition for 'ThrowIfGreaterThan'

Check failure on line 14 in src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ICollectionDebugView.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / runtime (Build osx-x64 Debug Mono_MiniJIT_LibrariesTests)

src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ICollectionDebugView.cs#L14

src/libraries/System.Private.CoreLib/src/System/Collections/Generic/ICollectionDebugView.cs(14,35): error CS0117: (NETCORE_ENGINEERING_TELEMETRY=Build) 'ArgumentNullException' does not contain a definition for 'ThrowIfNull'