-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cdac] Handle non-IL method descs in RuntimeTypeSystem_1.GetMethodClassificationDataType
#110602
Merged
elinor-fung
merged 5 commits into
dotnet:main
from
elinor-fung:cdac-methodClassification
Dec 13, 2024
Merged
[cdac] Handle non-IL method descs in RuntimeTypeSystem_1.GetMethodClassificationDataType
#110602
elinor-fung
merged 5 commits into
dotnet:main
from
elinor-fung:cdac-methodClassification
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinor-fung
requested review from
davidwrighton,
AaronRobinsonMSFT and
max-charlamb
December 11, 2024 04:43
dotnet-issue-labeler
bot
added
the
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
label
Dec 11, 2024
elinor-fung
added
area-Diagnostics-coreclr
and removed
needs-area-label
An area label is needed to ensure this gets routed to the appropriate area owners
labels
Dec 11, 2024
Tagging subscribers to this area: @tommcdon |
11 tasks
This was referenced Dec 11, 2024
tommcdon
added
the
enhancement
Product code improvement that does NOT require public API changes/additions
label
Dec 11, 2024
Open
3 tasks
AaronRobinsonMSFT
approved these changes
Dec 12, 2024
/ba-g failure is #110285 |
hez2010
pushed a commit
to hez2010/runtime
that referenced
this pull request
Dec 14, 2024
…assificationDataType` (dotnet#110602) - Add the different method desc types to the data descriptor - We only need their size right now - Add tests for different method desc classifications - Mostly fill-in for things I found we didn't cover - `GetNativeCode_StableEntryPoint_NonVtableSlot` is the one that actually hits the updated code in this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-Diagnostics-coreclr
enhancement
Product code improvement that does NOT require public API changes/additions
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetNativeCode_StableEntryPoint_NonVtableSlot
is the one that actually hits the updated code in this changeContributes to #99302, #109426