Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdac] Handle non-IL method descs in RuntimeTypeSystem_1.GetMethodClassificationDataType #110602

Merged
merged 5 commits into from
Dec 13, 2024

Conversation

elinor-fung
Copy link
Member

  • Add the different method desc types to the data descriptor
    • We only need their size right now
  • Add tests for different method desc classifications
    • Mostly fill-in for things I found we didn't cover - GetNativeCode_StableEntryPoint_NonVtableSlot is the one that actually hits the updated code in this change

Contributes to #99302, #109426

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Dec 11, 2024
@elinor-fung elinor-fung added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Dec 11, 2024
@elinor-fung elinor-fung added this to the 10.0.0 milestone Dec 11, 2024
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@tommcdon tommcdon added the enhancement Product code improvement that does NOT require public API changes/additions label Dec 11, 2024
@elinor-fung
Copy link
Member Author

/ba-g failure is #110285

@elinor-fung elinor-fung merged commit 90dfc04 into dotnet:main Dec 13, 2024
145 of 147 checks passed
@elinor-fung elinor-fung deleted the cdac-methodClassification branch December 13, 2024 20:26
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
…assificationDataType` (dotnet#110602)

- Add the different method desc types to the data descriptor
  - We only need their size right now
- Add tests for different method desc classifications
  - Mostly fill-in for things I found we didn't cover - `GetNativeCode_StableEntryPoint_NonVtableSlot` is the one that actually hits the updated code in this change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Diagnostics-coreclr enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants