Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize AsVector, AsVector128, GetUpper, As and WithElement with ARM64 intrinsics #37338

Merged
merged 6 commits into from
Jun 3, 2020

Conversation

kunalspathak
Copy link
Member

@kunalspathak kunalspathak commented Jun 3, 2020

Optimize some more APIs with ARM64 hardware intrinsics:

Contributes to #33308 and #33496.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jun 3, 2020
@kunalspathak
Copy link
Member Author

Thanks @tannergooding for reviewing.

@echesakovMSFT , @TamarChristinaArm.

@kunalspathak kunalspathak marked this pull request as ready for review June 3, 2020 21:26
@kunalspathak kunalspathak changed the title More hwintrinsic Optimize AsVector, AsVector128, GetUpper, As and WithElement with ARM64 intrinsics Jun 3, 2020
@TamarChristinaArm
Copy link
Contributor

Thanks @kunalspathak! I think you have a ticket for this right?

        53003C00          uxth    w0, w0
        4E0A1C10          ins     v16.h[2], w0

That there's no zero extension needed here? I think I remember this being discussed when Insert was added?

@kunalspathak
Copy link
Member Author

Thanks @kunalspathak! I think you have a ticket for this right?

        53003C00          uxth    w0, w0
        4E0A1C10          ins     v16.h[2], w0

That there's no zero extension needed here? I think I remember this being discussed when Insert was added?

Yep, its here. #35590 (comment)

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants