Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Download Symbols from microsoft symbol server #40690

Merged
merged 24 commits into from
Sep 15, 2020
Merged

[wasm] Download Symbols from microsoft symbol server #40690

merged 24 commits into from
Sep 15, 2020

Commits on Aug 12, 2020

  1. Creating a draft to download symbols from microsoft symbol server whe… 

    …n there is an exception and exceptions are turned on on debugger.

This is a workaround while VS doesn't work on it, which should be the final solution.
    @thaystg
    thaystg committed Aug 12, 2020
    Configuration menu
    Copy the full SHA
    67075a6 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2020

  1. Fix what lewing suggested.

    @thaystg
    thaystg committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    45c6f81 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2020

  1. Changing what @radical suggested.

    @thaystg
    thaystg committed Aug 17, 2020
    Configuration menu
    Copy the full SHA
    34932d6 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. Changed what @radical suggested.

    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b94e6d5 View commit details
    Browse the repository at this point in the history

  2. Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    thaystg and radical authored Aug 25, 2020
    Configuration menu
    Copy the full SHA
    4f29f82 View commit details
    Browse the repository at this point in the history

  3. Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    thaystg and radical authored Aug 25, 2020
    Configuration menu
    Copy the full SHA
    07cc6ca View commit details
    Browse the repository at this point in the history

  4. If it's not available on a URL try in the next one in the list.

    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    64c1ef9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'thays_load_symbols_from_ms_symbol_server' of github.com… 

    …:thaystg/runtime into thays_load_symbols_from_ms_symbol_server
    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    9792356 View commit details
    Browse the repository at this point in the history

  6. Logging error and adding comment about SDSR

    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b4f55d8 View commit details
    Browse the repository at this point in the history

  7. Returning if we find the method even if we have an exception sending … 

    …files to browser.
    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    9f41f60 View commit details
    Browse the repository at this point in the history

  8. Logging when we don't find the pdb.

    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    e8a13d3 View commit details
    Browse the repository at this point in the history

  9. Changing what @radical suggested.

    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    b8c48e3 View commit details
    Browse the repository at this point in the history

  10. Avoiding that we try to load symbols from the same assembly more than… 

    … once.
    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    076eb42 View commit details
    Browse the repository at this point in the history

  11. Simplifying and adding more log.

    @thaystg
    thaystg committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    bdfc1c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs 

    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    @thaystg @lewing
    thaystg and lewing authored Aug 26, 2020
    Configuration menu
    Copy the full SHA
    429907f View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Adding support for receive the urlSymbolServer as a parameter in the … 

    …request as discussed with Diego:

Diego: The response from vs code is that this shouldn't live in js-debug, so I think that passing it around in inspectUri would be the best approach for us
    @thaystg
    thaystg committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    7598ac9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into thays_load_symbol… 

    …s_from_ms_symbol_server
    @thaystg
    thaystg committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    12f45c9 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Fix @radical suggestion.

    @thaystg
    thaystg committed Sep 8, 2020
    Configuration menu
    Copy the full SHA
    8b955aa View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Removing default symbol server URL, like this we can land this on rc … 

    …5.0 without any risk of side effect.
    @thaystg
    thaystg committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    09729c4 View commit details
    Browse the repository at this point in the history

  2. Fix compilation.

    @thaystg
    thaystg committed Sep 14, 2020
    Configuration menu
    Copy the full SHA
    b989c8e View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2020

  1. Update src/mono/wasm/debugger/DebuggerTestSuite/TestHarnessStartup.cs 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    thaystg and radical authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    2d5812e View commit details
    Browse the repository at this point in the history

  2. Update src/mono/wasm/debugger/BrowserDebugHost/Startup.cs 

    Co-authored-by: Ankit Jain <radical@gmail.com>
    @thaystg @radical
    thaystg and radical authored Sep 15, 2020
    Configuration menu
    Copy the full SHA
    d72fc69 View commit details
    Browse the repository at this point in the history

  3. Accepting @radical suggestion.

    @thaystg
    thaystg committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    f9c93d2 View commit details
    Browse the repository at this point in the history

  4. Adding workaround on dotnet/runtime while PR 686 is not merged on Cec… 

    …il. When it's merged we will not get any side effect with this workaroud.
    @thaystg
    thaystg committed Sep 15, 2020
    Configuration menu
    Copy the full SHA
    729887b View commit details
    Browse the repository at this point in the history