[release/5.0] Fix OS version check and testhost copying in stress tests #41321

github-actions · 2020-08-25T11:34:51Z

Backport of #40980 and #41397 to release/5.0

Customer Impact

This PR fixes broken HTTP and SSL stress pipelines. No direct customer impact, but having the stress pipeline up and running is crucial to unblock investigation of stress failures we observed on the master branch.

Testing

Risk

None. No changes to production code.

ghost · 2020-08-25T11:34:55Z

Tagging subscribers to this area: @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

ghost · 2020-08-25T14:00:16Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

alnikola · 2020-08-25T14:42:56Z

/azp run runtime-libraries stress-http

azure-pipelines · 2020-08-25T14:43:07Z

Azure Pipelines successfully started running 1 pipeline(s).

alnikola · 2020-08-25T14:43:21Z

/azp run runtime-libraries stress-ssl

azure-pipelines · 2020-08-25T14:43:31Z

Azure Pipelines successfully started running 1 pipeline(s).

alnikola · 2020-08-25T15:34:04Z

@karelz We need to port it back to 5.0 to investigate stress test failures.

alnikola · 2020-08-25T16:11:26Z

We found an issue in the master branch. Holding off the backport for now.

Fixed docker files not using currently built runtime for http stress test.

ManickaP · 2020-08-28T10:25:42Z

/azp run runtime-libraries stress-http

azure-pipelines · 2020-08-28T10:25:50Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP · 2020-08-28T10:25:57Z

/azp run runtime-libraries stress-ssl

azure-pipelines · 2020-08-28T10:26:05Z

Azure Pipelines successfully started running 1 pipeline(s).

ManickaP · 2020-08-28T12:19:23Z

Linux: client_1 | System.Net.Http: /usr/share/dotnet/shared/Microsoft.NETCore.App/5.0.0-rc.1.20425.16/System.Net.Http.dll, modified 08/28/2020 11:09:07
Windows: client_1 | System.Net.Http: C:\Program Files\dotnet\shared\Microsoft.NETCore.App\5.0.0-rc.1.20425.16\System.Net.Http.dll, modified 8/28/2020 11:05:11 AM

Based on modified date, the tests are running on freshly built bits.

aik-jahoda

LGTM with nits

aik-jahoda · 2020-08-28T12:42:03Z

src/libraries/System.Net.Security/tests/StressTests/SslStress/Utils/ErrorAggregator.cs

+            public bool Equals([AllowNull] T left, [AllowNull] T right) => left != null && left.Equals(right, StructuralComparisons.StructuralEqualityComparer);
+            public int GetHashCode([DisallowNull] T value) => value.GetHashCode(StructuralComparisons.StructuralEqualityComparer);


Suggested change

public bool Equals([AllowNull] T left, [AllowNull] T right) => left != null && left.Equals(right, StructuralComparisons.StructuralEqualityComparer);

public int GetHashCode([DisallowNull] T value) => value.GetHashCode(StructuralComparisons.StructuralEqualityComparer);

public bool Equals(T? left, T? right) => left != null && left.Equals(right, StructuralComparisons.StructuralEqualityComparer);

public int GetHashCode(T value) => value.GetHashCode(StructuralComparisons.StructuralEqualityComparer);

Addressed in #41513, it's not necessary to be ported. The code works as-is.

aik-jahoda · 2020-08-28T12:42:46Z

src/libraries/System.Net.Http/tests/StressTests/HttpStress/StressClient.cs

+            public bool Equals([AllowNull] T left, [AllowNull] T right) => left != null && left.Equals(right, StructuralComparisons.StructuralEqualityComparer);
+            public int GetHashCode([DisallowNull] T value) => value.GetHashCode(StructuralComparisons.StructuralEqualityComparer);


Suggested change

public bool Equals([AllowNull] T left, [AllowNull] T right) => left != null && left.Equals(right, StructuralComparisons.StructuralEqualityComparer);

public int GetHashCode([DisallowNull] T value) => value.GetHashCode(StructuralComparisons.StructuralEqualityComparer);

public bool Equals(T? left, T? right) => left != null && left.Equals(right, StructuralComparisons.StructuralEqualityComparer);

public int GetHashCode(T value) => value.GetHashCode(StructuralComparisons.StructuralEqualityComparer);

Addressed in #41513, it's not necessary to be ported. The code works as-is.

ManickaP · 2020-08-28T13:50:34Z

CI runtime failure JIT\\Regression\\JitBlue\\Runtime_40444\\Runtime_40444\\Runtime_40444.cmd: #40885 --> seems like the fix is not backported in 5.0 branch.

ManickaP · 2020-08-28T17:37:37Z

The failures from http-stress test are being tracked in #40388. They're not the goal of this PR, this PR is just fixing the infra running the tests.

scalablecory

lgtm

scalablecory · 2020-08-28T17:54:49Z

@ericstj okay to merge this? no changes to product code, only to our test suite so we can run stress tests for 5.0.

ericstj

Approved. Test only

ericstj · 2020-08-28T17:59:50Z

Make sure it’s green or failures are understood and issues filed

ericstj · 2020-08-28T17:59:51Z

Make sure it’s green or failures are understood and issues filed

ManickaP · 2020-08-28T19:58:11Z

CI runtime failures:
HTTP: #41078
SMTP: unrelated, the change doesn't touch SMTP at all.

alnikola added 7 commits August 25, 2020 11:34

Stress test's nullability fixed

02bf0d0

Fix load testhost script

42f1563

Docker prints SDK version

31cd666

Generic constraints reverted

d904650

Nullability attributes added to Equals and GetHashCode arguments

b42c6f5

Target framework version set to 5.0.0

a3ef73d

Set version to 6.0.0

26e8832

Dotnet-GitSync-Bot added the area-Infrastructure-libraries label Aug 25, 2020

Set runtime version to 5.0.0

0bd9533

alnikola added the area-System.Net label Aug 25, 2020

alnikola requested a review from danmoseley August 25, 2020 15:33

alnikola marked this pull request as draft August 25, 2020 16:10

danmoseley removed the area-Infrastructure-libraries label Aug 25, 2020

karelz added this to the 5.0.0 milestone Aug 27, 2020

HTTP stress docker fix (#41397)

9868880

Fixed docker files not using currently built runtime for http stress test.

ManickaP self-assigned this Aug 28, 2020

aik-jahoda approved these changes Aug 28, 2020

View reviewed changes

ManickaP mentioned this pull request Aug 28, 2020

Fixed stress test pipeline and other issues. #41513

Merged

ManickaP marked this pull request as ready for review August 28, 2020 17:37

scalablecory approved these changes Aug 28, 2020

View reviewed changes

ericstj approved these changes Aug 28, 2020

View reviewed changes

ManickaP merged commit 10068f4 into release/5.0 Aug 28, 2020

ManickaP deleted the backport/pr-40980-to-release/5.0 branch August 28, 2020 19:58

ghost locked as resolved and limited conversation to collaborators Dec 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release/5.0] Fix OS version check and testhost copying in stress tests #41321

[release/5.0] Fix OS version check and testhost copying in stress tests #41321

github-actions bot commented Aug 25, 2020 •

edited by ManickaP

Loading

ghost commented Aug 25, 2020

ghost commented Aug 25, 2020

alnikola commented Aug 25, 2020

azure-pipelines bot commented Aug 25, 2020

alnikola commented Aug 25, 2020

azure-pipelines bot commented Aug 25, 2020

alnikola commented Aug 25, 2020

alnikola commented Aug 25, 2020

ManickaP commented Aug 28, 2020

azure-pipelines bot commented Aug 28, 2020

ManickaP commented Aug 28, 2020

azure-pipelines bot commented Aug 28, 2020

ManickaP commented Aug 28, 2020

aik-jahoda left a comment

aik-jahoda Aug 28, 2020

ManickaP Aug 28, 2020

aik-jahoda Aug 28, 2020

ManickaP Aug 28, 2020

ManickaP commented Aug 28, 2020

ManickaP commented Aug 28, 2020

scalablecory left a comment

scalablecory commented Aug 28, 2020

ericstj left a comment

ericstj commented Aug 28, 2020

ericstj commented Aug 28, 2020

ManickaP commented Aug 28, 2020

		public bool Equals([AllowNull] T left, [AllowNull] T right) => left != null && left.Equals(right, StructuralComparisons.StructuralEqualityComparer);
		public int GetHashCode([DisallowNull] T value) => value.GetHashCode(StructuralComparisons.StructuralEqualityComparer);

[release/5.0] Fix OS version check and testhost copying in stress tests #41321

[release/5.0] Fix OS version check and testhost copying in stress tests #41321

Conversation

github-actions bot commented Aug 25, 2020 • edited by ManickaP Loading

Customer Impact

Testing

Risk

ghost commented Aug 25, 2020

ghost commented Aug 25, 2020

alnikola commented Aug 25, 2020

azure-pipelines bot commented Aug 25, 2020

alnikola commented Aug 25, 2020

azure-pipelines bot commented Aug 25, 2020

alnikola commented Aug 25, 2020

alnikola commented Aug 25, 2020

ManickaP commented Aug 28, 2020

azure-pipelines bot commented Aug 28, 2020

ManickaP commented Aug 28, 2020

azure-pipelines bot commented Aug 28, 2020

ManickaP commented Aug 28, 2020

aik-jahoda left a comment

Choose a reason for hiding this comment

aik-jahoda Aug 28, 2020

Choose a reason for hiding this comment

ManickaP Aug 28, 2020

Choose a reason for hiding this comment

aik-jahoda Aug 28, 2020

Choose a reason for hiding this comment

ManickaP Aug 28, 2020

Choose a reason for hiding this comment

ManickaP commented Aug 28, 2020

ManickaP commented Aug 28, 2020

scalablecory left a comment

Choose a reason for hiding this comment

scalablecory commented Aug 28, 2020

ericstj left a comment

Choose a reason for hiding this comment

ericstj commented Aug 28, 2020

ericstj commented Aug 28, 2020

ManickaP commented Aug 28, 2020

github-actions bot commented Aug 25, 2020 •

edited by ManickaP

Loading