-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed stress test pipeline and other issues. #41513
Merged
ManickaP
merged 6 commits into
dotnet:master
from
ManickaP:mapichov/stress_nullability_fix
Sep 8, 2020
Merged
Fixed stress test pipeline and other issues. #41513
ManickaP
merged 6 commits into
dotnet:master
from
ManickaP:mapichov/stress_nullability_fix
Sep 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Tagging subscribers to this area: @dotnet/ncl |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ManickaP
force-pushed
the
mapichov/stress_nullability_fix
branch
from
August 31, 2020 19:30
436b4b8
to
2ea9623
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ManickaP
force-pushed
the
mapichov/stress_nullability_fix
branch
from
September 2, 2020 11:49
2ea9623
to
0d18d8b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ManickaP
force-pushed
the
mapichov/stress_nullability_fix
branch
from
September 3, 2020 18:26
f04a90d
to
577a7ff
Compare
wfurt
reviewed
Sep 3, 2020
ManickaP
changed the title
Fixed stress test nullability.
[WIP] Fixed stress test pipeline and other issues.
Sep 3, 2020
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ManickaP
force-pushed
the
mapichov/stress_nullability_fix
branch
from
September 4, 2020 15:39
577a7ff
to
1d5ed7e
Compare
ManickaP
force-pushed
the
mapichov/stress_nullability_fix
branch
from
September 7, 2020 09:45
1d5ed7e
to
57493a9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ManickaP
force-pushed
the
mapichov/stress_nullability_fix
branch
from
September 7, 2020 10:46
57493a9
to
f77e852
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ManickaP
changed the title
[WIP] Fixed stress test pipeline and other issues.
Fixed stress test pipeline and other issues.
Sep 7, 2020
alnikola
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses multiple issues with HTTP stress:
[DisallowNull]
in since that's the way it is in the interface: https://github.com/dotnet/runtime/blob/master/src/libraries/System.Private.CoreLib/src/System/Collections/Generic/IEqualityComparer.cs#L14