-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More tests for Marshal.Realloc{HGlobal|CoTaskMem} #41910
Conversation
...untime.InteropServices/tests/System/Runtime/InteropServices/Marshal/ReAllocCoTaskMemTests.cs
Outdated
Show resolved
Hide resolved
004fcf4
to
0bcbaaf
Compare
Mono arm64 debug call stack looks strange:
|
- The corner case behavior of Marshal.Realloc method is non-standard and differs between the two realloc methods. Capture the current behavior in tests. - Add temporary workarounds for Windows vs. Unix differences - Disable the tests on Mono for now More test tweaks
71f2ade
to
063cce5
Compare
@AaronRobinsonMSFT Could you please take a look? I would like to merge this PR and then update the tests in the other PR to document the change. My plan is to unify the corner cases that throw OOM on one platform and do not throw on other platform to not throw everywhere. It should minimize the breaking potential of the unification. |
The corner case behavior of Marshal.Realloc method is non-standard and differs between the two realloc methods. Capture it in tests.