Move Marshal memory allocation methods into CoreLib shared partition #41911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
requested review from
akoeplinger,
CoffeeFlux,
EgorBo,
lambdageek,
marek-safar,
steveisok,
thaystg and
vargaz
as code owners
jkotas
added
area-System.Runtime.InteropServices
NO-MERGE
|
Depends on #41910 |
|
The mono changes look ok to me. |
AaronRobinsonMSFT
approved these changes
Sep 5, 2020
CoffeeFlux
reviewed
Sep 5, 2020
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.Unix.cs
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.Unix.cs
Show resolved
Hide resolved
am11
reviewed
Sep 5, 2020
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.Unix.cs
Outdated
Show resolved
Hide resolved
am11
reviewed
Sep 5, 2020
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.Unix.cs
Show resolved
Hide resolved
am11
reviewed
Sep 5, 2020
src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.Unix.cs
Show resolved
Hide resolved
|
The mono/mono mirror PR appears to be passing all required lanes: mono/mono#20353 I don't have context for this PR and so I don't know why it's labeled no-merge, but whenever it's ready the Mono side looks good and I can merge it. |
jkotas
removed
the
NO-MERGE
I was improving tests in other PR that was just merged. Once the CI is green, this can be merged too. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to benefits from better sharing between runtimes, this change avoids unnecessary layers of wrappers on Unix and makes these methods significantly faster on average for small sizes. For example:
for (int i = 0; i < 100000000; i++) Marshal.FreeHGlobal(Marshal.AllocHGlobal(100));Before this change: 5430ms
After this change: 2030ms